From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: "Darrick J. Wong"
<darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>,
"Martin K. Petersen"
<martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Linux API <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
shane.seymour-ZPxbGqLxI0U@public.gmane.org,
Bruce Fields <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
linux-fsdevel
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jeff Layton <jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH 3/3] block: implement (some of) fallocate for block devices
Date: Sat, 5 Mar 2016 12:57:28 -0800 [thread overview]
Message-ID: <20160305205728.GA4834@infradead.org> (raw)
In-Reply-To: <CA+55aFyY+oDoK8C6C++PG=N+vtY-r1Y6fYO_3skDTzkP_SXC-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Fri, Mar 04, 2016 at 07:06:38PM -0800, Linus Torvalds wrote:
> > + if ((mode & FALLOC_FL_PUNCH_HOLE) &&
> > + (!blk_queue_discard(q) || !q->limits.discard_zeroes_data))
> > + return -EOPNOTSUPP;
>
> I'm ok with this, but suspect that some users would prefer to just
> turn this into ZERO_RANGE silently.
>
> Comments from people who would be expected to use this?
A hole punch should be a hole punch, and not silently allocate blocks
isntead of deallocating them. It's not even a fallback, it's pretty
much the opposite for some workloads.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
Theodore Ts'o <tytso@mit.edu>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Linux API <linux-api@vger.kernel.org>,
Dave Chinner <david@fromorbit.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
shane.seymour@hpe.com, Bruce Fields <bfields@fieldses.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Jeff Layton <jlayton@poochiereds.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/3] block: implement (some of) fallocate for block devices
Date: Sat, 5 Mar 2016 12:57:28 -0800 [thread overview]
Message-ID: <20160305205728.GA4834@infradead.org> (raw)
In-Reply-To: <CA+55aFyY+oDoK8C6C++PG=N+vtY-r1Y6fYO_3skDTzkP_SXC-A@mail.gmail.com>
On Fri, Mar 04, 2016 at 07:06:38PM -0800, Linus Torvalds wrote:
> > + if ((mode & FALLOC_FL_PUNCH_HOLE) &&
> > + (!blk_queue_discard(q) || !q->limits.discard_zeroes_data))
> > + return -EOPNOTSUPP;
>
> I'm ok with this, but suspect that some users would prefer to just
> turn this into ZERO_RANGE silently.
>
> Comments from people who would be expected to use this?
A hole punch should be a hole punch, and not silently allocate blocks
isntead of deallocating them. It's not even a fallback, it's pretty
much the opposite for some workloads.
next prev parent reply other threads:[~2016-03-05 20:57 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-05 0:55 [PATCH v6 0/3] fallocate for block devices to provide zero-out Darrick J. Wong
2016-03-05 0:55 ` Darrick J. Wong
2016-03-05 0:56 ` [PATCH 2/3] block: require write_same and discard requests align to logical block size Darrick J. Wong
2016-03-05 3:02 ` Linus Torvalds
2016-03-15 7:34 ` Christoph Hellwig
2016-03-05 0:56 ` [PATCH 3/3] block: implement (some of) fallocate for block devices Darrick J. Wong
[not found] ` <20160305005617.29738.85316.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-03-05 3:06 ` Linus Torvalds
2016-03-05 3:06 ` Linus Torvalds
[not found] ` <CA+55aFyY+oDoK8C6C++PG=N+vtY-r1Y6fYO_3skDTzkP_SXC-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-05 20:57 ` Christoph Hellwig [this message]
2016-03-05 20:57 ` Christoph Hellwig
2016-03-05 3:13 ` Linus Torvalds
2016-03-05 3:13 ` Linus Torvalds
[not found] ` <CA+55aFzJW70YApg8ra-c79E-j1ujOXbh=26k2dvyYX+qZuu_8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-05 20:58 ` Christoph Hellwig
2016-03-05 20:58 ` Christoph Hellwig
[not found] ` <20160305005556.29738.66782.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-03-05 0:56 ` [PATCH 1/3] block: invalidate the page cache when issuing BLKZEROOUT Darrick J. Wong
2016-03-05 0:56 ` Darrick J. Wong
[not found] ` <20160305005603.29738.58460.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-03-15 7:35 ` Christoph Hellwig
2016-03-15 7:35 ` Christoph Hellwig
2016-03-05 3:17 ` [PATCH v6 0/3] fallocate for block devices to provide zero-out Linus Torvalds
2016-03-05 3:17 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2016-03-15 19:42 [PATCH v7 " Darrick J. Wong
[not found] ` <20160315194221.30093.70506.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-03-15 19:42 ` [PATCH 3/3] block: implement (some of) fallocate for block devices Darrick J. Wong
2016-03-15 19:42 ` Darrick J. Wong
[not found] ` <20160315194244.30093.6483.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-03-21 15:38 ` Christoph Hellwig
2016-03-21 15:38 ` Christoph Hellwig
[not found] ` <20160321153827.GA27230-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-21 17:52 ` Darrick J. Wong
2016-03-21 17:52 ` Darrick J. Wong
[not found] ` <20160321175235.GA5812-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-03-21 18:17 ` Christoph Hellwig
2016-03-21 18:17 ` Christoph Hellwig
[not found] ` <20160321181726.GA10892-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-21 18:21 ` Martin K. Petersen
2016-03-21 18:21 ` Martin K. Petersen
2016-03-21 18:52 ` Mike Snitzer
2016-03-21 18:52 ` Mike Snitzer
2016-03-21 19:11 ` Darrick J. Wong
2016-03-21 19:11 ` Darrick J. Wong
2016-03-21 19:22 ` Mike Snitzer
[not found] ` <20160321192229.GA17220-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-21 20:59 ` Brian Foster
2016-03-21 20:59 ` Brian Foster
2016-04-13 4:01 [RFC DONOTMERGE v8 0/3] " Darrick J. Wong
[not found] ` <20160413040121.10562.98998.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-04-13 4:01 ` [PATCH 3/3] block: implement (some of) " Darrick J. Wong
2016-04-13 4:01 ` Darrick J. Wong
2016-04-13 4:01 ` Darrick J. Wong
2016-06-17 1:17 [PATCH v9 0/3] " Darrick J. Wong
[not found] ` <146612624734.12764.4316680863289411106.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-06-17 1:17 ` [PATCH 3/3] block: implement (some of) " Darrick J. Wong
2016-06-17 1:17 ` Darrick J. Wong
2016-06-17 1:17 ` Darrick J. Wong
2016-08-26 0:02 [PATCH v10 0/3] " Darrick J. Wong
2016-08-26 0:02 ` [PATCH 3/3] block: implement (some of) " Darrick J. Wong
2016-08-26 0:02 ` Darrick J. Wong
2016-09-29 0:39 [PATCH v10 0/3] " Darrick J. Wong
2016-09-29 0:39 ` [PATCH 3/3] block: implement (some of) " Darrick J. Wong
2016-09-29 0:39 ` Darrick J. Wong
2016-09-29 1:42 ` Bart Van Assche
2016-09-29 1:42 ` Bart Van Assche
2016-09-29 1:42 ` Bart Van Assche
2016-09-29 2:09 ` Darrick J. Wong
2016-09-29 2:09 ` Darrick J. Wong
2016-09-29 5:57 ` Hannes Reinecke
2016-09-29 5:57 ` Hannes Reinecke
2016-09-29 21:16 [PATCH v11 0/3] " Darrick J. Wong
2016-09-29 21:16 ` [PATCH 3/3] block: implement (some of) " Darrick J. Wong
2016-09-29 21:16 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305205728.GA4834@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \
--cc=darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org \
--cc=jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=shane.seymour-ZPxbGqLxI0U@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=tytso-3s7WtUTddSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.