From: Sandhya Bankar <bankarsandhya512@gmail.com>
To: outreachy-kernel@googlegroups.com
Subject: [PATCH v2] Staging: dgnc: Add block comments /* and */ on a separate line in dgnc_tty.c.
Date: Sun, 6 Mar 2016 13:48:50 +0530 [thread overview]
Message-ID: <20160306081850.GA1185@sandhya> (raw)
Add block comments /* and */ on a separate line. The warning is reported by checkpatch.pl.
The preferred style for long (multi-line) comments is:
/*
*
*
*/
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
Changes in v2:
* No change.
*Compile this patch to check nothing is broken.
drivers/staging/dgnc/dgnc_tty.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 0c0a26f..c90a458 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -443,7 +443,8 @@ void dgnc_tty_uninit(struct dgnc_board *brd)
brd->PrintDriver.termios = NULL;
}
-/*=======================================================================
+/*
+ *=======================================================================
*
* dgnc_wmove - Write data to transmit queue.
*
@@ -451,7 +452,8 @@ void dgnc_tty_uninit(struct dgnc_board *brd)
* buf - Pointer to characters to be moved.
* n - Number of characters to move.
*
- *=======================================================================*/
+ *=======================================================================
+ */
static void dgnc_wmove(struct channel_t *ch, char *buf, uint n)
{
int remain;
@@ -489,13 +491,15 @@ static void dgnc_wmove(struct channel_t *ch, char *buf, uint n)
ch->ch_w_head = head;
}
-/*=======================================================================
+/*
+ *=======================================================================
*
* dgnc_input - Process received data.
*
* ch - Pointer to channel structure.
*
- *=======================================================================*/
+ *=======================================================================
+ */
void dgnc_input(struct channel_t *ch)
{
struct dgnc_board *bd;
--
1.8.3.4
next reply other threads:[~2016-03-06 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 8:18 Sandhya Bankar [this message]
2016-03-11 21:33 ` [Outreachy kernel] [PATCH v2] Staging: dgnc: Add block comments /* and */ on a separate line in dgnc_tty.c Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306081850.GA1185@sandhya \
--to=bankarsandhya512@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.