[PATCH v2] Staging: dgnc: Add block comments /* and */ on a separate line in dgnc_tty.c.

[PATCH v2] Staging: dgnc: Add block comments /* and */ on a separate line in dgnc_tty.c.

[Sandhya Bankar]

Add block comments /* and */ on a separate line. The warning is reported by checkpatch.pl.

The preferred style for long (multi-line) comments is:
/*
 *
 *
 */


Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
Changes in v2:
* No change.
*Compile this patch to check nothing is broken.

 drivers/staging/dgnc/dgnc_tty.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 0c0a26f..c90a458 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -443,7 +443,8 @@ void dgnc_tty_uninit(struct dgnc_board *brd)
 	brd->PrintDriver.termios = NULL;
 }
 
-/*=======================================================================
+/*
+ *=======================================================================
  *
  *	dgnc_wmove - Write data to transmit queue.
  *
@@ -451,7 +452,8 @@ void dgnc_tty_uninit(struct dgnc_board *brd)
  *		buf	- Pointer to characters to be moved.
  *		n	- Number of characters to move.
  *
- *=======================================================================*/
+ *=======================================================================
+ */
 static void dgnc_wmove(struct channel_t *ch, char *buf, uint n)
 {
 	int	remain;
@@ -489,13 +491,15 @@ static void dgnc_wmove(struct channel_t *ch, char *buf, uint n)
 	ch->ch_w_head = head;
 }
 
-/*=======================================================================
+/*
+ *=======================================================================
  *
  *      dgnc_input - Process received data.
  *
  *	      ch      - Pointer to channel structure.
  *
- *=======================================================================*/
+ *=======================================================================
+ */
 void dgnc_input(struct channel_t *ch)
 {
 	struct dgnc_board *bd;
-- 
1.8.3.4

Re: [Outreachy kernel] [PATCH v2] Staging: dgnc: Add block comments /* and */ on a separate line in dgnc_tty.c.

[Greg KH]

On Sun, Mar 06, 2016 at 01:48:50PM +0530, Sandhya Bankar wrote:
> Add block comments /* and */ on a separate line. The warning is reported by checkpatch.pl.
> 
> The preferred style for long (multi-line) comments is:
> /*
>  *
>  *
>  */
> 
> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> Changes in v2:
> * No change.
> *Compile this patch to check nothing is broken.
> 
>  drivers/staging/dgnc/dgnc_tty.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

Doesn't apply to my tree :(