* [PATCH] Staging: gs_fpgaboot: Fix multiple coding style issues.
@ 2016-03-06 11:24 Sandhya Bankar
2016-03-11 21:35 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sandhya Bankar @ 2016-03-06 11:24 UTC (permalink / raw)
To: outreachy-kernel
Fix below coding style issues.
- Fix alignment to match open parenthesis.
- Use space around '+'.
- Remove unnecessary blank lines.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index fe3a6bc..96432c5 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -93,7 +93,6 @@ static int readlength_bitstream(char *bitdata, int *lendata, int *offset)
return 0;
}
-
/*
* read first 13 bytes to check bitstream magic number
*/
@@ -201,7 +200,7 @@ static int gs_download_image(struct fpgaimage *fimage, enum wbus bus_bytes)
#endif /* DEBUG_FPGA */
if (!xl_supported_prog_bus_width(bus_bytes)) {
pr_err("unsupported program bus width %d\n",
- bus_bytes);
+ bus_bytes);
return -1;
}
@@ -222,7 +221,7 @@ static int gs_download_image(struct fpgaimage *fimage, enum wbus bus_bytes)
pr_info("device init done\n");
for (i = 0; i < size; i += bus_bytes)
- xl_shift_bytes_out(bus_bytes, bitdata+i);
+ xl_shift_bytes_out(bus_bytes, bitdata + i);
pr_info("program done\n");
@@ -277,7 +276,7 @@ static int gs_set_download_method(struct fpgaimage *fimage)
static int init_driver(void)
{
firmware_pdev = platform_device_register_simple("fpgaboot", -1,
- NULL, 0);
+ NULL, 0);
return PTR_ERR_OR_ZERO(firmware_pdev);
}
@@ -336,7 +335,6 @@ err_out1:
kfree(fimage);
return -1;
-
}
static int __init gs_fpgaboot_init(void)
--
1.8.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: gs_fpgaboot: Fix multiple coding style issues.
2016-03-06 11:24 [PATCH] Staging: gs_fpgaboot: Fix multiple coding style issues Sandhya Bankar
@ 2016-03-11 21:35 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-03-11 21:35 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel
On Sun, Mar 06, 2016 at 04:54:24PM +0530, Sandhya Bankar wrote:
> Fix below coding style issues.
> - Fix alignment to match open parenthesis.
> - Use space around '+'.
> - Remove unnecessary blank lines.
This should be 3 different patches.
Also you have trailing whitespace in your changelog comments :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-11 21:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-06 11:24 [PATCH] Staging: gs_fpgaboot: Fix multiple coding style issues Sandhya Bankar
2016-03-11 21:35 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.