All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@gnu.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Thomas Huth <thuth@redhat.com>,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	Li Zhijian <lizhijian@cn.fujitsu.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	Jason Wang <jasowang@redhat.com>,
	qemu-devel@nongnu.org, Vasiliy Tolstov <v.tolstov@selfip.ru>,
	Dave Gilbert <dgilbert@redhat.com>,
	Gonglei <arei.gonglei@huawei.com>,
	Huangpeng <peter.huangpeng@huawei.com>,
	Guillaume Subiron <maethor@subiron.org>
Subject: Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode
Date: Sun, 6 Mar 2016 17:59:54 +0100	[thread overview]
Message-ID: <20160306165954.GJ2710@var.home> (raw)
In-Reply-To: <56D9AEC8.50707@siemens.com>

Hello,

Jan Kiszka, on Fri 04 Mar 2016 16:50:32 +0100, wrote:
> On 2016-03-04 09:41, Thomas Huth wrote:
> > On 22.02.2016 20:28, Samuel Thibault wrote:
> >> Hello,
> >>
> >> This is another respin of IPv6 in Qemu -net user mode.
> >>
> >> These patches add ICMPv6, NDP, make UDP and TCP compatible with IPv6, and add
> >> TFTP over IPv6.
> > 
> > *ping*
> > 
> >  Jan, Jason,
> > 
> > could you please have a look at this series? Would be cool to include it
> > for 2.6 so that we'd finally have IPv6 support in Slirp, too.
> > As far as I could see, the patches look fine now - there was just one
> > rather cosmetic issue left in patch 9/10, but it should also be ok in
> > the current shape already, I think, so IMHO no need for a respin.
> 
> As indicated before, we need someone else than me to manage the slirp
> system. I'm out of bandwidth for this task, sorry.

Ok, Jason?

I'm really surprised that a patch that has been reviewed two times (by
me then by Thomas) seems so difficult to get it.  I understand that
it's far from trivial, but I have concerns with how qemu can manage
contributions.

Samuel

  reply	other threads:[~2016-03-06 17:00 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22 19:28 [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode Samuel Thibault
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration Samuel Thibault
2016-03-07  6:53   ` Jason Wang
2016-03-07 11:24     ` Samuel Thibault
2016-03-08  1:39       ` Jason Wang
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 02/10] slirp: Adding ICMPv6 error sending Samuel Thibault
2016-03-07  6:55   ` Jason Wang
2016-03-07 13:34     ` Samuel Thibault
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support Samuel Thibault
2016-03-07  6:57   ` Jason Wang
2016-03-07 11:36     ` Samuel Thibault
2016-03-08  1:40       ` Jason Wang
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 04/10] slirp: Factorizing tcpiphdr structure with an union Samuel Thibault
2016-02-23  8:07   ` Thomas Huth
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 05/10] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff Samuel Thibault
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 06/10] slirp: Reindent after refactoring Samuel Thibault
2016-03-07  7:02   ` Jason Wang
2016-03-07 11:38     ` Samuel Thibault
2016-03-08  1:43       ` Jason Wang
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 07/10] slirp: Handle IPv6 in TCP functions Samuel Thibault
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 08/10] slirp: Adding IPv6 address for DNS relay Samuel Thibault
2016-02-23  8:12   ` Thomas Huth
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 09/10] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses Samuel Thibault
2016-02-23  8:27   ` Thomas Huth
2016-03-07  7:05   ` Jason Wang
2016-03-07 11:39     ` Samuel Thibault
2016-03-07 11:41     ` Samuel Thibault
2016-03-07 16:05       ` Eric Blake
2016-02-22 19:28 ` [Qemu-devel] [PATCHv9 10/10] slirp: Add IPv6 support to the TFTP code Samuel Thibault
2016-03-04  8:41 ` [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode Thomas Huth
2016-03-04 15:50   ` Jan Kiszka
2016-03-06 16:59     ` Samuel Thibault [this message]
2016-03-07  5:03       ` Jason Wang
2016-03-07 11:09         ` Samuel Thibault
2016-03-07 12:06           ` Jan Kiszka
2016-03-07 12:11             ` Samuel Thibault
2016-03-07 12:14             ` Thomas Huth
2016-03-07 12:16               ` Jan Kiszka
2016-03-08  2:50                 ` Jason Wang
2016-03-08  1:37           ` Jason Wang
2016-03-07  6:48 ` Jason Wang
2016-03-07 11:19   ` Samuel Thibault
2016-03-07 12:00     ` Thomas Huth
2016-03-07 13:37       ` Samuel Thibault
2016-03-08  2:48     ` Jason Wang
2016-03-08  8:53       ` Samuel Thibault
2016-03-07 11:55   ` Samuel Thibault
2016-03-07 15:37     ` Thomas Huth
2016-03-07 16:49       ` Samuel Thibault
2016-03-08  2:15     ` Jason Wang
2016-03-08  9:12       ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160306165954.GJ2710@var.home \
    --to=samuel.thibault@gnu.org \
    --cc=arei.gonglei@huawei.com \
    --cc=dgilbert@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jasowang@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=maethor@subiron.org \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=thuth@redhat.com \
    --cc=v.tolstov@selfip.ru \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.