Re: [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode

[Samuel Thibault <samuel.thibault@gnu.org>]

Jason Wang, on Tue 08 Mar 2016 10:48:27 +0800, wrote:
> ./scripts/checkpatch.pl
> 0001-slirp-Adding-IPv6-ICMPv6-Echo-and-NDP-autoconfigurat.patch
> ERROR: return is not a function, parentheses are not required
> #177: FILE: slirp/ip6.h:65:
> +    return (a->s6_addr[prefix_len / 8] & ((1U << (8 - (prefix_len %
> 8))) - 1))

This is a false positive, the parentheses here are part of the
expression.

> WARNING: line over 80 characters
> #270: FILE: slirp/ip6_icmp.c:14:
> +#define NDP_Interval g_rand_int_range(slirp->grand,
> NDP_MinRtrAdvInterval, NDP_MaxRtrAdvInterval)

That was a real one yes, introduced when I was asked to use
g_rand_int_range, I have fixed it already.

> WARNING: if this code is redundant consider removing it
> #870: FILE: slirp/ip6_input.c:52:
> +#if 0

That's what we discuss in the other mail.  Yes, we can use comments.  It
just looks odd that we are talking about some code which goes away in a
subsequent patch :)

> >> - The patches do not apply to master cleanly.
> > It did at the time I sent them...
> 
> Right, but not now, so please rebase.

Sure... Already done so.

Samuel