From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Mark Brown" <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Priit Laes" <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>,
"Chen-Yu Tsai" <wens-jdAy2FN1RRM@public.gmane.org>,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"Linux Kernel Mailing List"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Emilio López" <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>
Subject: Re: [PATCH 1/2] spi: sun4i: add DMA support
Date: Sun, 6 Mar 2016 22:42:06 +0100 [thread overview]
Message-ID: <20160306214206.GW8418@lukather> (raw)
In-Reply-To: <CAOMqctTz=szSkpk95D_dUJjjpziCKoPv=xRczjfq2Roct-K-OA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]
On Fri, Feb 26, 2016 at 01:51:51PM +0100, Michal Suchanek wrote:
> Hello,
>
> On 26 February 2016 at 13:25, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > On Fri, Feb 26, 2016 at 07:56:56AM +0200, Priit Laes wrote:
> >> From: Emilio López <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>
> >>
> >> This patch adds support for 64 byte or bigger transfers on the
> >> sun4i SPI controller. Said transfers will be performed via DMA.
> >>
> >> Signed-off-by: Emilio López <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>
> >> Tested-by: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> Tested-by: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
> >> ---
> >
> > You *must* sign off any patches you are sending, please see
> > SubmittingPatches.
>
> I have sent these patches in the past.
Mike's point was that since it's Priit that he's submitting the
patches, he must add his SoB.
> Besides this non-technical objection there were multiple technical
> objections.
>
> IIRC one was that the driver does not handle the case when the DMA
> channels are not available. As I understand it the channels are
> exclusively reserved for a particular peripherial on sunxi platform so
> this ShoulNotHappen(tm). So it's probably fine for the driver to fail
> probe when you have broken DT or no DMA engine support for sunxi
> platform.
There's a quite trivial scenario that would trigger this: if the dma
driver or dmaengine is not enabled / loaded.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] spi: sun4i: add DMA support
Date: Sun, 6 Mar 2016 22:42:06 +0100 [thread overview]
Message-ID: <20160306214206.GW8418@lukather> (raw)
In-Reply-To: <CAOMqctTz=szSkpk95D_dUJjjpziCKoPv=xRczjfq2Roct-K-OA@mail.gmail.com>
On Fri, Feb 26, 2016 at 01:51:51PM +0100, Michal Suchanek wrote:
> Hello,
>
> On 26 February 2016 at 13:25, Mark Brown <broonie@kernel.org> wrote:
> > On Fri, Feb 26, 2016 at 07:56:56AM +0200, Priit Laes wrote:
> >> From: Emilio L?pez <emilio@elopez.com.ar>
> >>
> >> This patch adds support for 64 byte or bigger transfers on the
> >> sun4i SPI controller. Said transfers will be performed via DMA.
> >>
> >> Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
> >> Tested-by: Michal Suchanek <hramrach@gmail.com>
> >> Tested-by: Priit Laes <plaes@plaes.org>
> >> ---
> >
> > You *must* sign off any patches you are sending, please see
> > SubmittingPatches.
>
> I have sent these patches in the past.
Mike's point was that since it's Priit that he's submitting the
patches, he must add his SoB.
> Besides this non-technical objection there were multiple technical
> objections.
>
> IIRC one was that the driver does not handle the case when the DMA
> channels are not available. As I understand it the channels are
> exclusively reserved for a particular peripherial on sunxi platform so
> this ShoulNotHappen(tm). So it's probably fine for the driver to fail
> probe when you have broken DT or no DMA engine support for sunxi
> platform.
There's a quite trivial scenario that would trigger this: if the dma
driver or dmaengine is not enabled / loaded.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160306/056db8b7/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Michal Suchanek <hramrach@gmail.com>
Cc: "Mark Brown" <broonie@kernel.org>, "Priit Laes" <plaes@plaes.org>,
"Chen-Yu Tsai" <wens@csie.org>,
linux-spi <linux-spi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Emilio López" <emilio@elopez.com.ar>
Subject: Re: [PATCH 1/2] spi: sun4i: add DMA support
Date: Sun, 6 Mar 2016 22:42:06 +0100 [thread overview]
Message-ID: <20160306214206.GW8418@lukather> (raw)
In-Reply-To: <CAOMqctTz=szSkpk95D_dUJjjpziCKoPv=xRczjfq2Roct-K-OA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]
On Fri, Feb 26, 2016 at 01:51:51PM +0100, Michal Suchanek wrote:
> Hello,
>
> On 26 February 2016 at 13:25, Mark Brown <broonie@kernel.org> wrote:
> > On Fri, Feb 26, 2016 at 07:56:56AM +0200, Priit Laes wrote:
> >> From: Emilio López <emilio@elopez.com.ar>
> >>
> >> This patch adds support for 64 byte or bigger transfers on the
> >> sun4i SPI controller. Said transfers will be performed via DMA.
> >>
> >> Signed-off-by: Emilio López <emilio@elopez.com.ar>
> >> Tested-by: Michal Suchanek <hramrach@gmail.com>
> >> Tested-by: Priit Laes <plaes@plaes.org>
> >> ---
> >
> > You *must* sign off any patches you are sending, please see
> > SubmittingPatches.
>
> I have sent these patches in the past.
Mike's point was that since it's Priit that he's submitting the
patches, he must add his SoB.
> Besides this non-technical objection there were multiple technical
> objections.
>
> IIRC one was that the driver does not handle the case when the DMA
> channels are not available. As I understand it the channels are
> exclusively reserved for a particular peripherial on sunxi platform so
> this ShoulNotHappen(tm). So it's probably fine for the driver to fail
> probe when you have broken DT or no DMA engine support for sunxi
> platform.
There's a quite trivial scenario that would trigger this: if the dma
driver or dmaengine is not enabled / loaded.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-06 21:42 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 5:56 [PATCH RESEND 0/2] spi: sun4i: add DMA support Priit Laes
2016-02-26 5:56 ` Priit Laes
2016-02-26 5:56 ` [PATCH 1/2] " Priit Laes
2016-02-26 5:56 ` Priit Laes
[not found] ` <1456466217-6793-2-git-send-email-plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2016-02-26 12:25 ` Mark Brown
2016-02-26 12:25 ` Mark Brown
2016-02-26 12:25 ` Mark Brown
[not found] ` <20160226122504.GR18327-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-02-26 12:51 ` Michal Suchanek
2016-02-26 12:51 ` Michal Suchanek
2016-02-26 12:51 ` Michal Suchanek
[not found] ` <CAOMqctTz=szSkpk95D_dUJjjpziCKoPv=xRczjfq2Roct-K-OA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-06 21:42 ` Maxime Ripard [this message]
2016-03-06 21:42 ` Maxime Ripard
2016-03-06 21:42 ` Maxime Ripard
2016-03-10 9:01 ` Michal Suchanek
2016-03-10 9:01 ` Michal Suchanek
2016-03-10 9:01 ` Michal Suchanek
[not found] ` <CAOMqctQ5aq0A95ErVVF13f_8JBy0xRw9_FZ3avbYmZUGXp=Svg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-17 7:27 ` Maxime Ripard
2016-03-17 7:27 ` Maxime Ripard
2016-03-17 7:27 ` Maxime Ripard
2016-03-17 10:58 ` Michal Suchanek
2016-03-17 10:58 ` Michal Suchanek
2016-03-17 10:58 ` Michal Suchanek
[not found] ` <CAOMqctQzMhR_bf=rMyROcTAPcrgx2EBqhH+qJL=b-U=iG9ZF4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-17 11:43 ` Mark Brown
2016-03-17 11:43 ` Mark Brown
2016-03-17 11:43 ` Mark Brown
[not found] ` <20160317114308.GF2566-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-03-17 11:54 ` Michal Suchanek
2016-03-17 11:54 ` Michal Suchanek
2016-03-17 11:54 ` Michal Suchanek
[not found] ` <CAOMqctSoA5WxtBCUK0PoHTV9OBi_fw4mdqOw+Dc_1DB_jghqng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-17 11:58 ` Mark Brown
2016-03-17 11:58 ` Mark Brown
2016-03-17 11:58 ` Mark Brown
2016-03-18 20:23 ` Maxime Ripard
2016-03-18 20:23 ` Maxime Ripard
2016-03-18 20:33 ` Mark Brown
2016-03-18 20:33 ` Mark Brown
2016-03-18 20:33 ` Mark Brown
[not found] ` <1456466217-6793-1-git-send-email-plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2016-02-26 5:56 ` [PATCH 2/2] ARM: sunxi: spi: add notice about SPI FIFO limit Priit Laes
2016-02-26 5:56 ` Priit Laes
2016-02-26 5:56 ` Priit Laes
[not found] ` <1456466217-6793-3-git-send-email-plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2016-03-06 18:12 ` Maxime Ripard
2016-03-06 18:12 ` Maxime Ripard
2016-03-06 18:12 ` Maxime Ripard
2016-02-26 12:15 ` [PATCH RESEND 0/2] spi: sun4i: add DMA support Mark Brown
2016-02-26 12:15 ` Mark Brown
2016-02-26 12:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306214206.GW8418@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org \
--cc=hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.