From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] arm64: dts: Add dts files for LG Electronics's lg1312 SoC
Date: Mon, 7 Mar 2016 05:26:39 +0100 [thread overview]
Message-ID: <201603070526.40020.arnd@arndb.de> (raw)
In-Reply-To: <1457323800-26904-4-git-send-email-chanho.min@lge.com>
On Monday 07 March 2016, Chanho Min wrote:
> +
> + chosen {
> + bootargs = "root=/dev/nfs ip=dhcp";
> + };
Can you add a stdout-path property as well, to make the console work?
Please also include an aliases node in the .dts file.
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +#define ARMV8_TIMER_IRQ_TYPE (GIC_CPU_MASK_RAW(0x0f) | IRQ_TYPE_LEVEL_LOW)
I would leave out the macro here and instead just open-code this in the place it
is used.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Chanho Min <chanho.min@lge.com>,
arm@kernel.org, Catalin Marinas <catalin.marinas@arm.com>,
Gunho Lee <gunho.lee@lge.com>, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Jongsung Kim <neidhard.kim@lge.com>
Subject: Re: [PATCH 3/4] arm64: dts: Add dts files for LG Electronics's lg1312 SoC
Date: Mon, 7 Mar 2016 05:26:39 +0100 [thread overview]
Message-ID: <201603070526.40020.arnd@arndb.de> (raw)
In-Reply-To: <1457323800-26904-4-git-send-email-chanho.min@lge.com>
On Monday 07 March 2016, Chanho Min wrote:
> +
> + chosen {
> + bootargs = "root=/dev/nfs ip=dhcp";
> + };
Can you add a stdout-path property as well, to make the console work?
Please also include an aliases node in the .dts file.
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +#define ARMV8_TIMER_IRQ_TYPE (GIC_CPU_MASK_RAW(0x0f) | IRQ_TYPE_LEVEL_LOW)
I would leave out the macro here and instead just open-code this in the place it
is used.
Arnd
next prev parent reply other threads:[~2016-03-07 4:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 4:09 [PATCH 0/4] ARM64:SoC add a new platform, LG Electronics's lg1k Chanho Min
2016-03-07 4:09 ` Chanho Min
2016-03-07 4:09 ` [PATCH 1/4] arm64: add Kconfig entry for LG1K SoC family Chanho Min
2016-03-07 4:09 ` Chanho Min
2016-03-07 4:09 ` [PATCH 2/4] arm64: defconfig: enable ARCH_LG1K Chanho Min
2016-03-07 4:09 ` Chanho Min
2016-03-07 4:09 ` [PATCH 3/4] arm64: dts: Add dts files for LG Electronics's lg1312 SoC Chanho Min
2016-03-07 4:09 ` Chanho Min
2016-03-07 1:59 ` Mark Rutland
2016-03-07 1:59 ` Mark Rutland
2016-03-09 10:21 ` Chanho Min
2016-03-09 10:21 ` Chanho Min
2016-03-07 4:26 ` Arnd Bergmann [this message]
2016-03-07 4:26 ` Arnd Bergmann
2016-03-07 4:10 ` [PATCH 4/4] MAINTAINERS: add myself as ARM/LG1K maintainer Chanho Min
2016-03-07 4:10 ` Chanho Min
2016-03-07 4:29 ` [PATCH 0/4] ARM64:SoC add a new platform, LG Electronics's lg1k Arnd Bergmann
2016-03-07 4:29 ` Arnd Bergmann
2016-03-07 6:45 ` Chanho Min
2016-03-07 6:45 ` Chanho Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201603070526.40020.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.