From: Thierry Reding <thierry.reding@gmail.com>
To: Matt Longnecker <mlongnecker@nvidia.com>
Cc: Wei Ni <wni@nvidia.com>,
rui.zhang@intel.com, mikko.perttunen@kapsi.fi,
swarren@wwwdotorg.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature
Date: Mon, 7 Mar 2016 09:32:24 +0100 [thread overview]
Message-ID: <20160307083224.GB31189@ulmo.nvidia.com> (raw)
In-Reply-To: <56D78081.6050106@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
On Wed, Mar 02, 2016 at 04:08:33PM -0800, Matt Longnecker wrote:
>
>
> On 03/01/2016 11:40 PM, Wei Ni wrote:
> >>diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c
> >>index 74ea5765938b..136975220c92 100644
> >>--- a/drivers/thermal/tegra_soctherm.c
> >>+++ b/drivers/thermal/tegra_soctherm.c
> >>@@ -57,7 +57,7 @@
> >> #define READBACK_VALUE_MASK 0xff00
> >> #define READBACK_VALUE_SHIFT 8
> >> #define READBACK_ADD_HALF BIT(7)
> >>-#define READBACK_NEGATE BIT(1)
> >>+#define READBACK_NEGATE BIT(0)
> I confirm that this change is technically correct. It fixes a bug.
That usually translates to a Reviewed-by: tag. =)
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-07 8:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 9:51 [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Wei Ni
2016-02-29 9:51 ` Wei Ni
[not found] ` <1456739480-3304-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-02 7:40 ` Wei Ni
2016-03-02 7:40 ` Wei Ni
[not found] ` <56D698FE.7070706-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-03 0:08 ` Matt Longnecker
2016-03-03 0:08 ` Matt Longnecker
[not found] ` <56D78081.6050106-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-07 8:26 ` Wei Ni
2016-03-07 8:26 ` Wei Ni
[not found] ` <56DD3B1E.4030805-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-07 8:55 ` Zhang, Rui
2016-03-07 8:55 ` Zhang, Rui
[not found] ` <744357E9AAD1214791ACBA4B0B9092633A9721DE-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-03-07 9:16 ` Wei Ni
2016-03-07 9:16 ` Wei Ni
2016-03-07 12:27 ` Zhang, Rui
2016-03-07 8:32 ` Thierry Reding [this message]
2016-03-07 8:38 ` Thierry Reding
2016-03-07 8:38 ` Thierry Reding
[not found] ` <20160307083842.GC31189-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2016-03-07 8:45 ` Wei Ni
2016-03-07 8:45 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307083224.GB31189@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mikko.perttunen@kapsi.fi \
--cc=mlongnecker@nvidia.com \
--cc=rui.zhang@intel.com \
--cc=swarren@wwwdotorg.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.