From: Sudip Mukherjee <sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Peter Meerwald <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iio: adc: imx25-gcq: fix do_div
Date: Mon, 7 Mar 2016 16:36:32 +0530 [thread overview]
Message-ID: <20160307110632.GA10337@sudip-pc> (raw)
In-Reply-To: <8010548.jDMIC4yOG6@adelgunde>
On Mon, Mar 07, 2016 at 10:01:34AM +0100, Markus Pargmann wrote:
> Hi,
>
> On Saturday 05 March 2016 18:43:11 Jonathan Cameron wrote:
> > On 03/03/16 12:51, Sudip Mukherjee wrote:
> > > We are getting build failure with tilepro allmodconfig with the error:
> > >
> > > drivers/iio/adc/fsl-imx25-gcq.c:236:4: note: in expansion of macro 'do_div'
> > > do_div(priv->channel_vref_mv[reg], 1000);
> > > ^
> > >
> > > include/asm-generic/div64.h:198:17: note: expected 'uint64_t *
> > > {aka long long unsigned int *}' but argument is of type 'u32 *
> > > {aka unsigned int *}'
> > >
> > > Create a temporary variable of type u64 and use that in do_div.
> > >
> > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
> > Markus, can you take a quick look at this.
>
> Thanks. I think this was already fixed by Arnd.
> "iio: adc/imx25-gcq: move incorrect do_div"
It should. But I still have the same build failure with next-20160307
and not only tilepro, even m32r is also having the same build failure.
regards
sudip
WARNING: multiple messages have this Message-ID (diff)
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: adc: imx25-gcq: fix do_div
Date: Mon, 7 Mar 2016 16:36:32 +0530 [thread overview]
Message-ID: <20160307110632.GA10337@sudip-pc> (raw)
In-Reply-To: <8010548.jDMIC4yOG6@adelgunde>
On Mon, Mar 07, 2016 at 10:01:34AM +0100, Markus Pargmann wrote:
> Hi,
>
> On Saturday 05 March 2016 18:43:11 Jonathan Cameron wrote:
> > On 03/03/16 12:51, Sudip Mukherjee wrote:
> > > We are getting build failure with tilepro allmodconfig with the error:
> > >
> > > drivers/iio/adc/fsl-imx25-gcq.c:236:4: note: in expansion of macro 'do_div'
> > > do_div(priv->channel_vref_mv[reg], 1000);
> > > ^
> > >
> > > include/asm-generic/div64.h:198:17: note: expected 'uint64_t *
> > > {aka long long unsigned int *}' but argument is of type 'u32 *
> > > {aka unsigned int *}'
> > >
> > > Create a temporary variable of type u64 and use that in do_div.
> > >
> > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> > Markus, can you take a quick look at this.
>
> Thanks. I think this was already fixed by Arnd.
> "iio: adc/imx25-gcq: move incorrect do_div"
It should. But I still have the same build failure with next-20160307
and not only tilepro, even m32r is also having the same build failure.
regards
sudip
next prev parent reply other threads:[~2016-03-07 11:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 12:51 [PATCH] iio: adc: imx25-gcq: fix do_div Sudip Mukherjee
2016-03-03 12:51 ` Sudip Mukherjee
[not found] ` <1457009513-7069-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-05 18:43 ` Jonathan Cameron
2016-03-05 18:43 ` Jonathan Cameron
[not found] ` <56DB28BF.9070508-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-03-07 9:01 ` Markus Pargmann
2016-03-07 9:01 ` Markus Pargmann
2016-03-07 11:06 ` Sudip Mukherjee [this message]
2016-03-07 11:06 ` Sudip Mukherjee
2016-03-12 11:09 ` Jonathan Cameron
2016-03-12 11:09 ` Jonathan Cameron
2016-03-16 8:39 ` Lee Jones
2016-03-16 8:39 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307110632.GA10337@sudip-pc \
--to=sudipm.mukherjee-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=kernel-testers-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.