From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/14] mfd: ipaq-micro: use __maybe_unused to hide pm functions
Date: Tue, 8 Mar 2016 11:27:31 +0700 [thread overview]
Message-ID: <20160308042731.GG13692@x1> (raw)
In-Reply-To: <1456934350-1389172-6-git-send-email-arnd@arndb.de>
On Wed, 02 Mar 2016, Arnd Bergmann wrote:
> The ipaq-micro driver uses SET_SYSTEM_SLEEP_PM_OPS() to
> remove the reference to its resume function, but does
> not use an #ifdef around the definition, so we get
> a build warning:
>
> drivers/mfd/ipaq-micro.c:379:12: error: 'micro_resume' defined but not used [-Werror=unused-function]
>
> This adds a __maybe_unused annotation so the compiler knows
> it can silently drop it instead of warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mfd/ipaq-micro.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
> index a41859c55bda..df16fd1df68b 100644
> --- a/drivers/mfd/ipaq-micro.c
> +++ b/drivers/mfd/ipaq-micro.c
> @@ -376,7 +376,7 @@ static const struct mfd_cell micro_cells[] = {
> { .name = "ipaq-micro-leds", },
> };
>
> -static int micro_resume(struct device *dev)
> +static int __maybe_unused micro_resume(struct device *dev)
> {
> struct ipaq_micro *micro = dev_get_drvdata(dev);
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/14] mfd: ipaq-micro: use __maybe_unused to hide pm functions
Date: Tue, 8 Mar 2016 11:27:31 +0700 [thread overview]
Message-ID: <20160308042731.GG13692@x1> (raw)
In-Reply-To: <1456934350-1389172-6-git-send-email-arnd@arndb.de>
On Wed, 02 Mar 2016, Arnd Bergmann wrote:
> The ipaq-micro driver uses SET_SYSTEM_SLEEP_PM_OPS() to
> remove the reference to its resume function, but does
> not use an #ifdef around the definition, so we get
> a build warning:
>
> drivers/mfd/ipaq-micro.c:379:12: error: 'micro_resume' defined but not used [-Werror=unused-function]
>
> This adds a __maybe_unused annotation so the compiler knows
> it can silently drop it instead of warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mfd/ipaq-micro.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
> index a41859c55bda..df16fd1df68b 100644
> --- a/drivers/mfd/ipaq-micro.c
> +++ b/drivers/mfd/ipaq-micro.c
> @@ -376,7 +376,7 @@ static const struct mfd_cell micro_cells[] = {
> { .name = "ipaq-micro-leds", },
> };
>
> -static int micro_resume(struct device *dev)
> +static int __maybe_unused micro_resume(struct device *dev)
> {
> struct ipaq_micro *micro = dev_get_drvdata(dev);
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-03-08 4:27 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 15:58 [PATCH 00/14] drivers: use __maybe_unused to hide pm functions Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-02 15:58 ` [PATCH 01/14] pinctrl: at91: " Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-02 16:06 ` Nicolas Ferre
2016-03-02 16:06 ` Nicolas Ferre
2016-03-02 16:06 ` Nicolas Ferre
2016-03-02 16:47 ` Ludovic Desroches
2016-03-02 16:47 ` Ludovic Desroches
2016-03-02 16:47 ` Ludovic Desroches
2016-03-09 4:09 ` Linus Walleij
2016-03-09 4:09 ` Linus Walleij
2016-03-02 15:58 ` [PATCH 02/14] irqchip: st: use __maybe_unused to hide st_irq_syscfg_resume Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-02 15:58 ` [PATCH 03/14] power: ipaq-micro-battery: use __maybe_unused to hide pm functions Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-03 14:23 ` Sebastian Reichel
2016-03-03 14:23 ` Sebastian Reichel
2016-03-02 15:58 ` [PATCH 04/14] power: pm2301-charger: " Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-03 14:23 ` Sebastian Reichel
2016-03-03 14:23 ` Sebastian Reichel
2016-03-02 15:58 ` [PATCH 05/14] mfd: ipaq-micro: " Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-08 4:27 ` Lee Jones [this message]
2016-03-08 4:27 ` Lee Jones
2016-03-02 15:58 ` [PATCH 06/14] dma: sirf: " Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-03 3:47 ` Vinod Koul
2016-03-03 3:47 ` Vinod Koul
2016-03-03 12:33 ` Arnd Bergmann
2016-03-03 12:33 ` Arnd Bergmann
2016-03-04 15:02 ` Vinod Koul
2016-03-04 15:02 ` Vinod Koul
2016-03-02 15:58 ` [PATCH 07/14] hw_random: exynos: " Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-02 15:58 ` Arnd Bergmann
2016-03-02 23:43 ` Krzysztof Kozlowski
2016-03-02 23:43 ` Krzysztof Kozlowski
2016-03-11 13:31 ` Herbert Xu
2016-03-11 13:31 ` Herbert Xu
2016-03-02 15:59 ` [PATCH 08/14] scsi: mvumi: " Arnd Bergmann
2016-03-02 15:59 ` Arnd Bergmann
2016-03-03 8:30 ` Johannes Thumshirn
2016-03-03 8:30 ` Johannes Thumshirn
2016-03-05 22:08 ` Martin K. Petersen
2016-03-05 22:08 ` Martin K. Petersen
2016-03-02 15:59 ` [PATCH 09/14] amd-xgbe: " Arnd Bergmann
2016-03-02 15:59 ` Arnd Bergmann
2016-03-02 15:59 ` Arnd Bergmann
2016-03-02 15:59 ` [PATCH 10/14] wireless: cw1200: use __maybe_unused to hide pm functions_ Arnd Bergmann
2016-03-02 15:59 ` Arnd Bergmann
2016-03-08 10:33 ` [10/14] " Kalle Valo
2016-03-08 10:33 ` Kalle Valo
2016-03-08 10:33 ` Kalle Valo
2016-03-02 15:59 ` [PATCH 11/14] input: spear-keyboard: use __maybe_unused to hide pm functions Arnd Bergmann
2016-03-02 15:59 ` Arnd Bergmann
2016-03-02 17:12 ` Dmitry Torokhov
2016-03-02 17:12 ` Dmitry Torokhov
2016-03-02 15:59 ` [PATCH 12/14] keyboard: snvs-pwrkey: " Arnd Bergmann
2016-03-02 15:59 ` Arnd Bergmann
2016-03-02 16:04 ` Frank Li
2016-03-02 16:04 ` Frank Li
2016-03-02 16:04 ` Frank Li
2016-03-02 17:12 ` Dmitry Torokhov
2016-03-02 17:12 ` Dmitry Torokhov
2016-03-02 15:59 ` [PATCH 13/14] [media] omap3isp: use IS_ENABLED() " Arnd Bergmann
2016-03-02 15:59 ` Arnd Bergmann
2016-03-02 15:59 ` [PATCH 14/14] ASoC: rockchip: use __maybe_unused to hide st_irq_syscfg_resume Arnd Bergmann
2016-03-02 15:59 ` Arnd Bergmann
2016-03-02 15:59 ` Arnd Bergmann
2016-03-05 12:25 ` Applied "ASoC: rockchip: use __maybe_unused to hide st_irq_syscfg_resume" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308042731.GG13692@x1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.