From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: rtlwifi: Fix size of wireless mode variable
Date: Tue, 8 Mar 2016 10:32:26 +0000 (UTC) [thread overview]
Message-ID: <20160308103226.BDDB760897@smtp.codeaurora.org> (raw)
In-Reply-To: <1456419781-14722-1-git-send-email-Larry.Finger@lwfinger.net>
> Smatch reports the following warning:
>
> CHECK drivers/net/wireless/realtek/rtlwifi/rc.c
> drivers/net/wireless/realtek/rtlwifi/rc.c:144 _rtl_rc_rate_set_series() warn: impossible condition '(wireless_mode == 256) => (0-255 == 256)'
>
> This warning arises because commit acc6907b87a9 ("rtlwifi: Fix warning
> from ieee80211_get_tx_rates() when using 5G") now checks the wireless
> mode for WIRELESS_MODE_AC_ONLY (BIT(8)) in _rtl_rc_rate_set_series().
> As a result, all quantities used to store the wireless mode must be u16.
>
> This patch also reorders struct rtl_sta_info to save a little space.
>
> Fixes: d76d65fd2695 ("rtlwifi: fix broken VHT support")
> Reported-by: Dan Williams <dcbw@redhat.com>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
prev parent reply other threads:[~2016-03-08 10:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 17:03 [PATCH] rtlwifi: Fix size of wireless mode variable Larry Finger
2016-03-07 12:38 ` Kalle Valo
2016-03-07 14:47 ` Larry Finger
2016-03-08 8:50 ` Kalle Valo
2016-03-08 10:32 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308103226.BDDB760897@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.