Re: [PATCH] rtlwifi: Fix size of wireless mode variable

[Larry Finger <Larry.Finger@lwfinger.net>]

On 03/07/2016 06:38 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@lwfinger.net> writes:
>
>> Smatch reports the following warning:
>>
>>    CHECK   drivers/net/wireless/realtek/rtlwifi/rc.c
>> drivers/net/wireless/realtek/rtlwifi/rc.c:144 _rtl_rc_rate_set_series() warn: impossible condition '(wireless_mode == 256) => (0-255 == 256)'
>>
>> This warning arises because commit acc6907b87a9 ("rtlwifi: Fix warning
>> from ieee80211_get_tx_rates() when using 5G") now checks the wireless
>> mode for WIRELESS_MODE_AC_ONLY (BIT(8)) in _rtl_rc_rate_set_series().
>> As a result, all quantities used to store the wireless mode must be u16.
>>
>> This patch also reorders struct rtl_sta_info to save a little space.
>>
>> Fixes: commit acc6907b87a9 ("rtlwifi: Fix warning from ieee80211_get_tx_rates() when using 5G")
>> Reported-by: Dan Williams <dcbw@redhat.com>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> I can't find commit acc6907b87a9 from any of my trees. And oddly enough
> I can't either any commits with title "rtlwifi: Fix warning from
> ieee80211_get_tx_rates() when using 5G". I can fix it before commiting
> but what should I use?
>
> Also the fixes line should not have the word "commit".

Kalle,

I do not know where I got that commit and title. The correct reference is commit 
d76d65fd2695 ("rtlwifi: fix broken VHT support").

If you would rather not fix this on commit, I can submit a new version.

Thanks,

Larry