All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Shivani Bhardwaj <shivanib134@gmail.com>
Cc: Netfilter Development Mailing list <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] configure: Show support for connlabel
Date: Tue, 8 Mar 2016 14:37:58 +0100	[thread overview]
Message-ID: <20160308133758.GA5764@salvia> (raw)
In-Reply-To: <CAKHNQQFEtTkdrT9+f1i2XSG8+nk7ivCZz7bJcJm4tfbtGeCJtw@mail.gmail.com>

On Mon, Mar 07, 2016 at 11:36:33PM +0530, Shivani Bhardwaj wrote:
> On Mon, Mar 7, 2016 at 11:30 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Mon, Mar 07, 2016 at 06:56:46PM +0100, Pablo Neira Ayuso wrote:
> >> On Mon, Mar 07, 2016 at 11:05:15PM +0530, Shivani Bhardwaj wrote:
> >> > Yes, I'll do that.
> >> > I need a bit of help here.
> >> > I followed some other modules for which support has been mentioned.
> >> > For example, libipq
> >> > When I first ran the configure script, it turned out
> >> > IPQ support:                          no
> >> >
> >> > I did next time with the option --enable-libipq
> >> > As expected,
> >> > IPQ support:                          yes
> >> >
> >> > But, I tried writing the output of both these cases to files and when
> >> > I looked up for difference between the two, turned out only this IPQ
> >> > support line was different among them, in any case following was shown
> >> >
> >> >  config.status: creating libipq/Makefile
> >> >  config.status: creating libipq/libipq.pc
> >> >
> >> > (because this is a part of AC_CONFIG_FILES)
> >> >
> >> > I do not see any code associated with libipq in configure.ac.
> >> > May be I'm not understanding how these options are working, could you
> >> > please clarify a bit?
> >>
> >> Those are the userspace bits for the old ip_queue support that was
> >> removed years ago, since NFQUEUE superseded for many years.
> >>
> >> commit d16cf20e2f2f13411eece7f7fb72c17d141c4a84
> >> Author: Pablo Neira Ayuso <pablo@netfilter.org>
> >> Date:   Tue May 8 19:45:28 2012 +0200
> >>
> >>     netfilter: remove ip_queue support
> >>
> >> You can still cd iptables/libipq and type 'make' to compile the
> >> this small userspace library since we have to keep new iptables
> >> releases running with old kernels.
> >
> > Oh sorry, now I see.
> >
> > This is always compiling libipq even with --disable-libipq, this looks
> > like a bug in our build infrastructure.
> 
> Yes. Also, I see that devel should have --disable-devel instead of
> --enable-devel option and the appropriate functionality associated
> with it. Please correct me if I am wrong here.

So is --disable-devel also broken / being ignored? If so, that also
needs a fix, yes.

  reply	other threads:[~2016-03-08 13:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07  9:14 [PATCH] configure: Show support for connlabel Shivani Bhardwaj
2016-03-07 14:09 ` Pablo Neira Ayuso
2016-03-07 17:35   ` Shivani Bhardwaj
2016-03-07 17:56     ` Pablo Neira Ayuso
2016-03-07 18:00       ` Pablo Neira Ayuso
2016-03-07 18:06         ` Shivani Bhardwaj
2016-03-08 13:37           ` Pablo Neira Ayuso [this message]
2016-03-08 13:47             ` Jan Engelhardt
2016-03-08 13:54               ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160308133758.GA5764@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shivanib134@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.