From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Shivani Bhardwaj <shivanib134@gmail.com>,
Netfilter Development Mailing list
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] configure: Show support for connlabel
Date: Tue, 8 Mar 2016 14:54:23 +0100 [thread overview]
Message-ID: <20160308135423.GA10602@salvia> (raw)
In-Reply-To: <alpine.LSU.2.20.1603081441060.13514@nerf40.vanv.qr>
On Tue, Mar 08, 2016 at 02:47:13PM +0100, Jan Engelhardt wrote:
>
> On Tuesday 2016-03-08 14:37, Pablo Neira Ayuso wrote:
> >>>> Those are the userspace bits for the old ip_queue support that was
> >>>> removed years ago, since NFQUEUE superseded for many years.
> >>>> You can still cd iptables/libipq and type 'make' to compile the
> >>>> this small userspace library since we have to keep new iptables
> >>>> releases running with old kernels.
> >>>
> >>> This is always compiling libipq even with --disable-libipq, this looks
> >>> like a bug in our build infrastructure.
>
> If you manually and intentionally chdir to libipq and attempt to built it, why
> forbid it? Having "if ENABLE_LIBIPQ" in the toplevel Makefile.am seems
> sufficient.
That top level "if ENABLE_LIBIPQ" seems fine, I overlooked this.
> AS_HELP_STRING([--enable-libipq], [Build and install libipq])
> in configure.ac is also right, since ipq is build-disabled by default.
>
> >> Yes. Also, I see that devel should have --disable-devel instead of
> >> --enable-devel option and the appropriate functionality associated
> >> with it. Please correct me if I am wrong here.
>
> The help texts:
> AS_HELP_STRING([--enable-devel], [Install Xtables development headers])
> should indeed read
> AS_HELP_STRING([--disable-devel], [Avoid installation of Xtables development headers])
> because headers are build-*enabled* by default.
>
> But the actual option parsing (--enable-devel, --enable-devel=no,
> --disable-devel) that AC_ARG_ENABLE provides needs no change AFAICS.
Right, this is also controled via top level Makefile.am.
@Shivani, please focus on improving connlabel integration into our
configure thing.
prev parent reply other threads:[~2016-03-08 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 9:14 [PATCH] configure: Show support for connlabel Shivani Bhardwaj
2016-03-07 14:09 ` Pablo Neira Ayuso
2016-03-07 17:35 ` Shivani Bhardwaj
2016-03-07 17:56 ` Pablo Neira Ayuso
2016-03-07 18:00 ` Pablo Neira Ayuso
2016-03-07 18:06 ` Shivani Bhardwaj
2016-03-08 13:37 ` Pablo Neira Ayuso
2016-03-08 13:47 ` Jan Engelhardt
2016-03-08 13:54 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308135423.GA10602@salvia \
--to=pablo@netfilter.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.