[PATCH] pinctrl: pxa2xx: export symbols

[PATCH] pinctrl: pxa2xx: export symbols

[Linus Walleij]

The pxa2xxx fails some automated builds because of unexported
symbols.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/pinctrl/pxa/pinctrl-pxa2xx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
index d90e205cf809..f553313bc2ef 100644
--- a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
+++ b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
@@ -426,6 +426,7 @@ int pxa2xx_pinctrl_init(struct platform_device *pdev,
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(pxa2xx_pinctrl_init);
 
 int pxa2xx_pinctrl_exit(struct platform_device *pdev)
 {
@@ -434,3 +435,4 @@ int pxa2xx_pinctrl_exit(struct platform_device *pdev)
 	pinctrl_unregister(pctl->pctl_dev);
 	return 0;
 }
+EXPORT_SYMBOL_GPL(pxa2xx_pinctrl_exit);
-- 
2.4.3

[PATCH] pinctrl: pxa2xx: export symbols

[Linus Walleij]

The pxa2xxx fails some automated builds because of unexported
symbols.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/pinctrl/pxa/pinctrl-pxa2xx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
index d90e205cf809..f553313bc2ef 100644
--- a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
+++ b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
@@ -426,6 +426,7 @@ int pxa2xx_pinctrl_init(struct platform_device *pdev,
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(pxa2xx_pinctrl_init);
 
 int pxa2xx_pinctrl_exit(struct platform_device *pdev)
 {
@@ -434,3 +435,4 @@ int pxa2xx_pinctrl_exit(struct platform_device *pdev)
 	pinctrl_unregister(pctl->pctl_dev);
 	return 0;
 }
+EXPORT_SYMBOL_GPL(pxa2xx_pinctrl_exit);
-- 
2.4.3

Re: [PATCH] pinctrl: pxa2xx: export symbols

[Uwe Kleine-König]

On Wed, Mar 09, 2016 at 09:11:49AM +0700, Linus Walleij wrote:
> The pxa2xxx fails some automated builds because of unexported
> symbols.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

There is 3a5242e648a8d009f0e0fd47867592e5265374b6 in linus/master which
does a part of this patch already.

Apart from that I don't understand the patch. The only user of
pxa2xx_pinctrl_init is drivers/pinctrl/pxa/pinctrl-pxa27x.c[1] and this
is built into the same module as pinctrl-pxa2xx.o. So without testing I
wonder in which configuration this fails to build.

Best regards
Uwe

[1] git grep -E pxa2xx_pinctrl_\(in\|ex\)it next/master
    git grep -E pxa2xx_pinctrl_\(in\|ex\)it linus/master

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pinctrl: pxa2xx: export symbols

[Uwe Kleine-König]

On Wed, Mar 09, 2016 at 09:11:49AM +0700, Linus Walleij wrote:
> The pxa2xxx fails some automated builds because of unexported
> symbols.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

There is 3a5242e648a8d009f0e0fd47867592e5265374b6 in linus/master which
does a part of this patch already.

Apart from that I don't understand the patch. The only user of
pxa2xx_pinctrl_init is drivers/pinctrl/pxa/pinctrl-pxa27x.c[1] and this
is built into the same module as pinctrl-pxa2xx.o. So without testing I
wonder in which configuration this fails to build.

Best regards
Uwe

[1] git grep -E pxa2xx_pinctrl_\(in\|ex\)it next/master
    git grep -E pxa2xx_pinctrl_\(in\|ex\)it linus/master

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[PATCH] pinctrl: pxa2xx: export symbols

[Uwe Kleine-König]

On Wed, Mar 09, 2016 at 09:11:49AM +0700, Linus Walleij wrote:
> The pxa2xxx fails some automated builds because of unexported
> symbols.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

There is 3a5242e648a8d009f0e0fd47867592e5265374b6 in linus/master which
does a part of this patch already.

Apart from that I don't understand the patch. The only user of
pxa2xx_pinctrl_init is drivers/pinctrl/pxa/pinctrl-pxa27x.c[1] and this
is built into the same module as pinctrl-pxa2xx.o. So without testing I
wonder in which configuration this fails to build.

Best regards
Uwe

[1] git grep -E pxa2xx_pinctrl_\(in\|ex\)it next/master
    git grep -E pxa2xx_pinctrl_\(in\|ex\)it linus/master

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |