From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: don't use printf!
Date: Wed, 9 Mar 2016 10:28:26 -0800 [thread overview]
Message-ID: <20160309102826.2a1dcc7b@xeon-e3> (raw)
One thing I noticed while fixing mempool bug, was that there was a printf
in the library there. A reminder, code in DPDK library should never call printf
directly. printf in a real application is often ratholed off to /dev/null
and real output is through API's or syslog.
Offenders now:
rte_mempool
rte_acl
rte_cfgfile
I would fix rte_acl but it would require API breakage.
rte_acl_dump should take a FILE *
Some places have printf in debug path, which is less bad, but
still limits usage of DEBUG options
rte_sched
rte_timer
There are also several places in the BSD support, but I care less about those.
reply other threads:[~2016-03-09 18:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309102826.2a1dcc7b@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.