* re: drm: introduce pipe color correction properties
@ 2016-03-09 19:18 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-03-09 19:18 UTC (permalink / raw)
To: lionel.g.landwerlin; +Cc: dri-devel
Hello Lionel Landwerlin,
The patch 5488dc16fde7: "drm: introduce pipe color correction
properties" from Feb 26, 2016, leads to the following static checker
warning:
drivers/gpu/drm/drm_atomic_helper.c:2933 drm_atomic_helper_legacy_gamma_set()
error: 'blob' dereferencing possible ERR_PTR()
drivers/gpu/drm/drm_atomic_helper.c
2924 blob = drm_property_create_blob(dev,
2925 sizeof(struct drm_color_lut) * size,
2926 NULL);
2927 if (!blob) {
This should be a check for IS_ERR().
2928 ret = -ENOMEM;
2929 goto fail;
"goto fail" heh...
2930 }
2931
2932 /* Prepare GAMMA_LUT with the legacy values. */
2933 blob_data = (struct drm_color_lut *) blob->data;
2934 for (i = 0; i < size; i++) {
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-03-09 19:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-09 19:18 drm: introduce pipe color correction properties Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.