All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Brian Gerst <brgerst@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>, Waiman Long <waiman.long@hp.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 03/11] x86/mm/hotplug: Don't remove PGD entries in remove_pagetable()
Date: Thu, 10 Mar 2016 10:56:01 +0100	[thread overview]
Message-ID: <20160310095601.GA9677@gmail.com> (raw)
In-Reply-To: <CALCETrUijqLwS98M_EnW5OH=CSv_SwjKGC5FkAxFEcWiq0RM2A@mail.gmail.com>


* Andy Lutomirski <luto@amacapital.net> wrote:

> On Fri, Feb 12, 2016 at 11:04 AM, Andy Lutomirski <luto@amacapital.net> wrote:
> > On Mon, Sep 21, 2015 at 11:23 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >> So when memory hotplug removes a piece of physical memory from pagetable
> >> mappings, it also frees the underlying PGD entry.
> >>
> >> This complicates PGD management, so don't do this. We can keep the
> >> PGD mapped and the PUD table all clear - it's only a single 4K page
> >> per 512 GB of memory hotplugged.
> >
> > Ressurecting an ancient thread: I want this particular change to make
> > it (much) easier to make vmapped stacks work correctly.  Could it be
> > applied by itself?
> >
> 
> It's incomplete.  pageattr.c has another instance of the same thing.
> I'll see if I can make it work, but I may end up doing something a
> little different.

If so then mind picking up (and fixing ;-) tip:WIP.x86/mm in its entirety? It's 
well tested so shouldn't have too many easy to hit bugs. Feel free to rebase and 
restructure it, it's a WIP tree.

I keep getting distracted with other things but I'd hate if this got dropped on 
the floor.

Thanks,

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	Brian Gerst <brgerst@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>, Waiman Long <waiman.long@hp.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 03/11] x86/mm/hotplug: Don't remove PGD entries in remove_pagetable()
Date: Thu, 10 Mar 2016 10:56:01 +0100	[thread overview]
Message-ID: <20160310095601.GA9677@gmail.com> (raw)
In-Reply-To: <CALCETrUijqLwS98M_EnW5OH=CSv_SwjKGC5FkAxFEcWiq0RM2A@mail.gmail.com>


* Andy Lutomirski <luto@amacapital.net> wrote:

> On Fri, Feb 12, 2016 at 11:04 AM, Andy Lutomirski <luto@amacapital.net> wrote:
> > On Mon, Sep 21, 2015 at 11:23 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >> So when memory hotplug removes a piece of physical memory from pagetable
> >> mappings, it also frees the underlying PGD entry.
> >>
> >> This complicates PGD management, so don't do this. We can keep the
> >> PGD mapped and the PUD table all clear - it's only a single 4K page
> >> per 512 GB of memory hotplugged.
> >
> > Ressurecting an ancient thread: I want this particular change to make
> > it (much) easier to make vmapped stacks work correctly.  Could it be
> > applied by itself?
> >
> 
> It's incomplete.  pageattr.c has another instance of the same thing.
> I'll see if I can make it work, but I may end up doing something a
> little different.

If so then mind picking up (and fixing ;-) tip:WIP.x86/mm in its entirety? It's 
well tested so shouldn't have too many easy to hit bugs. Feel free to rebase and 
restructure it, it's a WIP tree.

I keep getting distracted with other things but I'd hate if this got dropped on 
the floor.

Thanks,

	Ingo

  reply	other threads:[~2016-03-10  9:56 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22  6:23 [PATCH 00/11] x86/mm: Implement lockless pgd_alloc()/pgd_free() Ingo Molnar
2015-09-22  6:23 ` Ingo Molnar
2015-09-22  6:23 ` [PATCH 01/11] x86/mm/pat: Don't free PGD entries on memory unmap Ingo Molnar
2015-09-22  6:23   ` Ingo Molnar
2015-09-22 17:41   ` Linus Torvalds
2015-09-22 17:41     ` Linus Torvalds
2015-09-22 18:03     ` Andy Lutomirski
2015-09-22 18:03       ` Andy Lutomirski
2015-09-22  6:23 ` [PATCH 02/11] x86/mm/hotplug: Remove pgd_list use from the memory hotplug code Ingo Molnar
2015-09-22  6:23   ` Ingo Molnar
2015-09-22 17:48   ` Linus Torvalds
2015-09-22 17:48     ` Linus Torvalds
2015-09-23 11:44     ` Oleg Nesterov
2015-09-23 11:44       ` Oleg Nesterov
2015-09-29  8:42       ` Ingo Molnar
2015-09-29  8:42         ` Ingo Molnar
2015-09-29 16:51         ` Oleg Nesterov
2015-09-29 16:51           ` Oleg Nesterov
2015-09-22  6:23 ` [PATCH 03/11] x86/mm/hotplug: Don't remove PGD entries in remove_pagetable() Ingo Molnar
2015-09-22  6:23   ` Ingo Molnar
2015-10-06  3:35   ` Kamezawa Hiroyuki
2015-10-06  3:35     ` Kamezawa Hiroyuki
2016-02-12 19:04   ` Andy Lutomirski
2016-02-12 19:04     ` Andy Lutomirski
2016-03-10  6:45     ` Andy Lutomirski
2016-03-10  6:45       ` Andy Lutomirski
2016-03-10  9:56       ` Ingo Molnar [this message]
2016-03-10  9:56         ` Ingo Molnar
2016-03-11  1:52         ` Andy Lutomirski
2016-03-11  1:52           ` Andy Lutomirski
2015-09-22  6:23 ` [PATCH 04/11] x86/mm/hotplug: Simplify sync_global_pgds() Ingo Molnar
2015-09-22  6:23   ` Ingo Molnar
2015-09-22  6:23 ` [PATCH 05/11] mm: Introduce arch_pgd_init_late() Ingo Molnar
2015-09-22  6:23   ` Ingo Molnar
2015-09-22 17:55   ` Linus Torvalds
2015-09-22 17:55     ` Linus Torvalds
2015-09-22 18:00     ` Andy Lutomirski
2015-09-22 18:00       ` Andy Lutomirski
2015-09-22 18:26       ` Linus Torvalds
2015-09-22 18:26         ` Linus Torvalds
2015-09-22 18:37         ` Andy Lutomirski
2015-09-22 18:37           ` Andy Lutomirski
2015-09-22 18:44           ` Linus Torvalds
2015-09-22 18:44             ` Linus Torvalds
2015-09-22 18:52             ` Andy Lutomirski
2015-09-22 18:52               ` Andy Lutomirski
2015-09-22  6:23 ` [PATCH 06/11] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code Ingo Molnar
2015-09-22  6:23   ` Ingo Molnar
2015-09-22 17:58   ` Linus Torvalds
2015-09-22 17:58     ` Linus Torvalds
2015-09-29  8:44     ` Ingo Molnar
2015-09-29  8:44       ` Ingo Molnar
2015-09-22  6:23 ` [PATCH 07/11] x86/mm: Remove pgd_list use from vmalloc_sync_all() Ingo Molnar
2015-09-22  6:23   ` Ingo Molnar
2015-09-22 17:59   ` Linus Torvalds
2015-09-22 17:59     ` Linus Torvalds
2015-09-22  6:23 ` [PATCH 08/11] x86/mm/pat/32: Remove pgd_list use from the PAT code Ingo Molnar
2015-09-22  6:23   ` Ingo Molnar
2015-09-22  6:23 ` [PATCH 09/11] x86/mm: Make pgd_alloc()/pgd_free() lockless Ingo Molnar
2015-09-22  6:23   ` Ingo Molnar
2015-09-22  6:23 ` [PATCH 10/11] x86/mm: Remove pgd_list leftovers Ingo Molnar
2015-09-22  6:23   ` Ingo Molnar
2015-09-22  6:23 ` [PATCH 11/11] x86/mm: Simplify pgd_alloc() Ingo Molnar
2015-09-22  6:23   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160310095601.GA9677@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@amacapital.net \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=waiman.long@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.