* [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers()
@ 2016-03-11 7:51 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2016-03-11 7:51 UTC (permalink / raw)
To: Oded Gabbay, Yair Shachar
Cc: David Airlie, dri-devel, linux-kernel, kernel-janitors
At the end of the function we expect "status" to be zero, but it's
either -EINVAL or unitialized.
Fixes: 788bf83db301 ('drm/amdkfd: Add wave control operation to debugger')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
index c34c393..d5e19b5 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
@@ -513,7 +513,7 @@ static int dbgdev_wave_control_set_registers(
union SQ_CMD_BITS *in_reg_sq_cmd,
union GRBM_GFX_INDEX_BITS *in_reg_gfx_index)
{
- int status;
+ int status = 0;
union SQ_CMD_BITS reg_sq_cmd;
union GRBM_GFX_INDEX_BITS reg_gfx_index;
struct HsaDbgWaveMsgAMDGen2 *pMsg;
^ permalink raw reply related [flat|nested] 5+ messages in thread* [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers()
@ 2016-03-11 7:51 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2016-03-11 7:51 UTC (permalink / raw)
To: Oded Gabbay, Yair Shachar
Cc: David Airlie, dri-devel, linux-kernel, kernel-janitors
At the end of the function we expect "status" to be zero, but it's
either -EINVAL or unitialized.
Fixes: 788bf83db301 ('drm/amdkfd: Add wave control operation to debugger')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
index c34c393..d5e19b5 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
@@ -513,7 +513,7 @@ static int dbgdev_wave_control_set_registers(
union SQ_CMD_BITS *in_reg_sq_cmd,
union GRBM_GFX_INDEX_BITS *in_reg_gfx_index)
{
- int status;
+ int status = 0;
union SQ_CMD_BITS reg_sq_cmd;
union GRBM_GFX_INDEX_BITS reg_gfx_index;
struct HsaDbgWaveMsgAMDGen2 *pMsg;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers()
2016-03-11 7:51 ` Dan Carpenter
(?)
@ 2016-03-14 13:57 ` Oded Gabbay
-1 siblings, 0 replies; 5+ messages in thread
From: Oded Gabbay @ 2016-03-14 13:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: kernel-janitors, Linux-Kernel@Vger. Kernel. Org,
Maling list - DRI developers
On Fri, Mar 11, 2016 at 9:51 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> At the end of the function we expect "status" to be zero, but it's
> either -EINVAL or unitialized.
>
> Fixes: 788bf83db301 ('drm/amdkfd: Add wave control operation to debugger')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> index c34c393..d5e19b5 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> @@ -513,7 +513,7 @@ static int dbgdev_wave_control_set_registers(
> union SQ_CMD_BITS *in_reg_sq_cmd,
> union GRBM_GFX_INDEX_BITS *in_reg_gfx_index)
> {
> - int status;
> + int status = 0;
> union SQ_CMD_BITS reg_sq_cmd;
> union GRBM_GFX_INDEX_BITS reg_gfx_index;
> struct HsaDbgWaveMsgAMDGen2 *pMsg;
Thanks,
applied to my fixes tree.
Oded
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers()
@ 2016-03-14 13:57 ` Oded Gabbay
0 siblings, 0 replies; 5+ messages in thread
From: Oded Gabbay @ 2016-03-14 13:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: Yair Shachar, David Airlie, Maling list - DRI developers,
Linux-Kernel@Vger. Kernel. Org, kernel-janitors
On Fri, Mar 11, 2016 at 9:51 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> At the end of the function we expect "status" to be zero, but it's
> either -EINVAL or unitialized.
>
> Fixes: 788bf83db301 ('drm/amdkfd: Add wave control operation to debugger')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> index c34c393..d5e19b5 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> @@ -513,7 +513,7 @@ static int dbgdev_wave_control_set_registers(
> union SQ_CMD_BITS *in_reg_sq_cmd,
> union GRBM_GFX_INDEX_BITS *in_reg_gfx_index)
> {
> - int status;
> + int status = 0;
> union SQ_CMD_BITS reg_sq_cmd;
> union GRBM_GFX_INDEX_BITS reg_gfx_index;
> struct HsaDbgWaveMsgAMDGen2 *pMsg;
Thanks,
applied to my fixes tree.
Oded
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers()
@ 2016-03-14 13:57 ` Oded Gabbay
0 siblings, 0 replies; 5+ messages in thread
From: Oded Gabbay @ 2016-03-14 13:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: kernel-janitors, Linux-Kernel@Vger. Kernel. Org,
Maling list - DRI developers
On Fri, Mar 11, 2016 at 9:51 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> At the end of the function we expect "status" to be zero, but it's
> either -EINVAL or unitialized.
>
> Fixes: 788bf83db301 ('drm/amdkfd: Add wave control operation to debugger')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> index c34c393..d5e19b5 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
> @@ -513,7 +513,7 @@ static int dbgdev_wave_control_set_registers(
> union SQ_CMD_BITS *in_reg_sq_cmd,
> union GRBM_GFX_INDEX_BITS *in_reg_gfx_index)
> {
> - int status;
> + int status = 0;
> union SQ_CMD_BITS reg_sq_cmd;
> union GRBM_GFX_INDEX_BITS reg_gfx_index;
> struct HsaDbgWaveMsgAMDGen2 *pMsg;
Thanks,
applied to my fixes tree.
Oded
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-14 13:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-11 7:51 [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers() Dan Carpenter
2016-03-11 7:51 ` Dan Carpenter
2016-03-14 13:57 ` Oded Gabbay
2016-03-14 13:57 ` Oded Gabbay
2016-03-14 13:57 ` Oded Gabbay
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.