Re: [PATCH v2 00/15] per project build directory

[Ed Bartosh <ed.bartosh@linux.intel.com>]

Hi Belen,

Thank you for the review. My comments are below.

On Wed, Mar 09, 2016 at 11:40:04AM +0000, Barros Pena, Belen wrote:
> >This is how to test this:
> > - run toaster
> > - run command line build: build zlib
> 
> This shows a warning about build history not being enabled. I know you
> already know about this, but just for completeness ;)
> 
Should be fixed in v3.

> > - check if it's shown in Toaster UI
> 
> Builds started from CLI do show in the web UI, but once they complete they
> are missing layer and package information. I guess that's connected with
> the build history issue above
> 
Most probably it is.

> > - create project for Yocto master
> > - trigger project build from UI
> 
> The build I triggered from the Toaster web UI from a Yocto master project
> (core-image-minimal) failed with this traceback:
> 
> /bin/sh: 1: source: not found
> 
> Traceback (most recent call last):
>   File 
> "/home/yocto/master/bitbake/lib/toaster/bldcontrol/management/commands/runb
> uilds.py", line 58, in schedule
>     br.brtarget_set.all(), "%d:%d" % (br.pk, bec.be.pk))
>   File 
> "/home/yocto/master/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
> ", line 261, in triggerBuild
>     self._shellcmd('source %s %s' % (oe_init, builddir), self.be.sourcedir)
>   File 
> "/home/yocto/master/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
> ", line 70, in _shellcmd
>     raise ShellCmdException(err)
> ShellCmdException: command: source
> /home/yocto/master/_toaster_clones/_git___git.yoctoproject.org_poky_master/
> oe-init-build-env /home/yocto/master/build-toaster-master project
> /bin/sh: 1: source: not found
> 
This is related to your shell (dash on Ubuntu I guess). Should be fixed
in v3.

> After all the above there is only one build directory created, the one
> that was generated when running the build from CLI. Also:
> 
> * I can no longer find the toaster_ui.log file
It will be in build directory. You didn't see it as toaster crashed and
didn't create build directory.

> * It looks like the builds are still using build/sstate-cache and
> build/downloads as SSTATE_DIR and DL_DIR, but I think we agreed that
> projects by default would share those 2 directories, which I guess means
> they have to move outside the build directory, although I could be mistaken
> 
This functionality is implemented in another patchset I think.
I'm going to make it working on top of my changes after I'm done with my
patchset. The same with build cancelation patchset - I'll make it
working after this one is accepted.

> * _toaster_clones is still being created in the root checkout directory,
> which I guess makes sense
> 
> * A pending question is where the toaster-custom-images layer we generate
> when building custom images should be. I had a brief chat with Michael
> about this, and I think we concluded the layer should not be shared across
> projects, which means we should create one per project and they should be
> inside the project build dir. Right now the _meta-toaster-custom directory
> is also in the root checkout directory
It makes sense to me. However, I'd rather not do it until this patchset
is tested and accepted. Otherwise amount of patches and new
functionality in this patchset will grow and it will be harder to
maintain it.

Thank you!
Ed