All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v3 4/4] staging: rtl8192e: Remove NULL test before vfree
Date: Fri, 11 Mar 2016 09:27:05 -0800	[thread overview]
Message-ID: <20160311172705.GA28090@kroah.com> (raw)
In-Reply-To: <20160228203102.GA2645@Karyakshetra>

On Mon, Feb 29, 2016 at 02:01:02AM +0530, Bhaktipriya Shridhar wrote:
> vfree frees the virtually continuous memory area starting at addr.
> If addr is NULL, no operation is performed. So NULL test is not needed
> before vfree.
> 
> This was done using Coccinelle:
> 
> @@
> expression x;
> @@
> -if (x != NULL)
>     vfree(x);
> 
> @@
> expression x;
> @@
> 
> -if (x != NULL) {
>    vfree(x);
>    x = NULL;
> -}
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Patch does not apply :(



      reply	other threads:[~2016-03-11 17:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-28 20:31 [PATCH v3 4/4] staging: rtl8192e: Remove NULL test before vfree Bhaktipriya Shridhar
2016-03-11 17:27 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160311172705.GA28090@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhaktipriya96@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.