* [PATCH v3 4/4] staging: rtl8192e: Remove NULL test before vfree
@ 2016-02-28 20:31 Bhaktipriya Shridhar
2016-03-11 17:27 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Bhaktipriya Shridhar @ 2016-02-28 20:31 UTC (permalink / raw)
To: outreachy-kernel
vfree frees the virtually continuous memory area starting at addr.
If addr is NULL, no operation is performed. So NULL test is not needed
before vfree.
This was done using Coccinelle:
@@
expression x;
@@
-if (x != NULL)
vfree(x);
@@
expression x;
@@
-if (x != NULL) {
vfree(x);
x = NULL;
-}
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 0b06482..6811702 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -2697,10 +2697,8 @@ static void _rtl92e_pci_disconnect(struct pci_dev *pdev)
priv->polling_timer_on = 0;
_rtl92e_down(dev, true);
rtl92e_dm_deinit(dev);
- if (priv->pFirmware) {
- vfree(priv->pFirmware);
- priv->pFirmware = NULL;
- }
+ vfree(priv->pFirmware);
+ priv->pFirmware = NULL;
destroy_workqueue(priv->priv_wq);
_rtl92e_free_rx_ring(dev);
for (i = 0; i < MAX_TX_QUEUE_COUNT; i++)
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Outreachy kernel] [PATCH v3 4/4] staging: rtl8192e: Remove NULL test before vfree
2016-02-28 20:31 [PATCH v3 4/4] staging: rtl8192e: Remove NULL test before vfree Bhaktipriya Shridhar
@ 2016-03-11 17:27 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-03-11 17:27 UTC (permalink / raw)
To: Bhaktipriya Shridhar; +Cc: outreachy-kernel
On Mon, Feb 29, 2016 at 02:01:02AM +0530, Bhaktipriya Shridhar wrote:
> vfree frees the virtually continuous memory area starting at addr.
> If addr is NULL, no operation is performed. So NULL test is not needed
> before vfree.
>
> This was done using Coccinelle:
>
> @@
> expression x;
> @@
> -if (x != NULL)
> vfree(x);
>
> @@
> expression x;
> @@
>
> -if (x != NULL) {
> vfree(x);
> x = NULL;
> -}
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Patch does not apply :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-11 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-28 20:31 [PATCH v3 4/4] staging: rtl8192e: Remove NULL test before vfree Bhaktipriya Shridhar
2016-03-11 17:27 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.