* [PATCH] Staging: goldfish: Add space around '+'
@ 2016-02-22 20:50 Dilek Uzulmez
2016-03-08 18:36 ` Dilek Uzulmez
2016-03-11 17:29 ` [Outreachy kernel] " Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Dilek Uzulmez @ 2016-02-22 20:50 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Dilek Uzulmez
Add space around operator '+'. Problem found using checkpatch.pl
CHECK: spaces preferred around that '+' (ctx:VxV)
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
---
drivers/staging/goldfish/goldfish_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
index b0927e4..f1e1838 100644
--- a/drivers/staging/goldfish/goldfish_audio.c
+++ b/drivers/staging/goldfish/goldfish_audio.c
@@ -63,7 +63,7 @@ struct goldfish_audio {
#define AUDIO_READ(data, addr) (readl(data->reg_base + addr))
#define AUDIO_WRITE(data, addr, x) (writel(x, data->reg_base + addr))
#define AUDIO_WRITE64(data, addr, addr2, x) \
- (gf_write_dma_addr((x), data->reg_base + addr, data->reg_base+addr2))
+ (gf_write_dma_addr((x), data->reg_base + addr, data->reg_base + addr2))
/*
* temporary variable used between goldfish_audio_probe() and
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: goldfish: Add space around '+'
2016-02-22 20:50 [PATCH] Staging: goldfish: Add space around '+' Dilek Uzulmez
@ 2016-03-08 18:36 ` Dilek Uzulmez
2016-03-11 17:29 ` [Outreachy kernel] " Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Dilek Uzulmez @ 2016-03-08 18:36 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
Did you check this ?
On Feb 22, 2016 10:50 PM, "Dilek Uzulmez" <dilekuzulmez@gmail.com> wrote:
> Add space around operator '+'. Problem found using checkpatch.pl
> CHECK: spaces preferred around that '+' (ctx:VxV)
>
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
> drivers/staging/goldfish/goldfish_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/goldfish/goldfish_audio.c
> b/drivers/staging/goldfish/goldfish_audio.c
> index b0927e4..f1e1838 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -63,7 +63,7 @@ struct goldfish_audio {
> #define AUDIO_READ(data, addr) (readl(data->reg_base + addr))
> #define AUDIO_WRITE(data, addr, x) (writel(x, data->reg_base + addr))
> #define AUDIO_WRITE64(data, addr, addr2, x) \
> - (gf_write_dma_addr((x), data->reg_base + addr,
> data->reg_base+addr2))
> + (gf_write_dma_addr((x), data->reg_base + addr, data->reg_base +
> addr2))
>
> /*
> * temporary variable used between goldfish_audio_probe() and
> --
> 1.9.1
>
>
[-- Attachment #2: Type: text/html, Size: 1613 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH] Staging: goldfish: Add space around '+'
2016-02-22 20:50 [PATCH] Staging: goldfish: Add space around '+' Dilek Uzulmez
2016-03-08 18:36 ` Dilek Uzulmez
@ 2016-03-11 17:29 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-03-11 17:29 UTC (permalink / raw)
To: Dilek Uzulmez; +Cc: outreachy-kernel
On Mon, Feb 22, 2016 at 10:50:08PM +0200, Dilek Uzulmez wrote:
> Add space around operator '+'. Problem found using checkpatch.pl
> CHECK: spaces preferred around that '+' (ctx:VxV)
>
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
> drivers/staging/goldfish/goldfish_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This doesn't apply to my tree at all, I think someone else already did
this :(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-11 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-22 20:50 [PATCH] Staging: goldfish: Add space around '+' Dilek Uzulmez
2016-03-08 18:36 ` Dilek Uzulmez
2016-03-11 17:29 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.