[PATCH] Staging: gdm724x: Use list_next_entry instead of list_entry

[PATCH] Staging: gdm724x: Use list_next_entry instead of list_entry

[Bhumika Goyal]

This patch replace list_entry with list_next_entry as it makes the code
more clear to read.
Done using coccinelle:

@@
expression e1;
identifier e3;
type t;
@@
(
- list_entry(e1->e3.next,t,e3)
+ list_next_entry(e1,e3)
|
- list_entry(e1->e3.prev,t,e3)
+ list_prev_entry(e1,e3)
)

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/staging/gdm724x/gdm_usb.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c
index 9db9b90..a19d210 100644
--- a/drivers/staging/gdm724x/gdm_usb.c
+++ b/drivers/staging/gdm724x/gdm_usb.c
@@ -227,7 +227,7 @@ static struct usb_rx *get_rx_struct(struct rx_cxt *rx, int *no_spc)
 		return NULL;
 	}
 
-	r = list_entry(rx->free_list.next, struct usb_rx, free_list);
+	r = list_next_entry(rx, free_list);
 	list_del(&r->free_list);
 
 	rx->avail_count--;
@@ -402,8 +402,7 @@ static void do_rx(struct work_struct *work)
 			spin_unlock_irqrestore(&rx->to_host_lock, flags);
 			break;
 		}
-		r = list_entry(rx->to_host_list.next,
-			       struct usb_rx, to_host_list);
+		r = list_next_entry(rx, to_host_list);
 		list_del(&r->to_host_list);
 		spin_unlock_irqrestore(&rx->to_host_lock, flags);
 
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: gdm724x: Use list_next_entry instead of list_entry

[Greg KH]

On Sun, Mar 06, 2016 at 08:26:30PM +0530, Bhumika Goyal wrote:
> This patch replace list_entry with list_next_entry as it makes the code
> more clear to read.
> Done using coccinelle:
> 
> @@
> expression e1;
> identifier e3;
> type t;
> @@
> (
> - list_entry(e1->e3.next,t,e3)
> + list_next_entry(e1,e3)
> |
> - list_entry(e1->e3.prev,t,e3)
> + list_prev_entry(e1,e3)
> )
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/staging/gdm724x/gdm_usb.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Driver is no longer in the tree, sorry.