* [PATCH] staging: android: binder: fixed line over 80 caracters
@ 2016-03-12 23:40 Juliana Rodrigues
2016-03-13 0:28 ` [Outreachy kernel] " Greg KH
2016-03-13 0:29 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Juliana Rodrigues @ 2016-03-12 23:40 UTC (permalink / raw)
To: outreachy-kernel
This patch fixes the following warning caused by checkpatch.pl:
WARNING: line over 80 characters
+ if (thread->looper & (BINDER_LOOPER_STATE_REGISTERED | BINDER_LOOPER_STATE_ENTERED)) {
Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
---
drivers/android/binder.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 7d00b7a..94190fc 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2054,7 +2054,9 @@ static int binder_thread_write(struct binder_proc *proc,
ref->death = NULL;
if (list_empty(&death->work.entry)) {
death->work.type = BINDER_WORK_CLEAR_DEATH_NOTIFICATION;
- if (thread->looper & (BINDER_LOOPER_STATE_REGISTERED | BINDER_LOOPER_STATE_ENTERED)) {
+ if (thread->looper & (
+ BINDER_LOOPER_STATE_REGISTERED |
+ BINDER_LOOPER_STATE_ENTERED)) {
list_add_tail(&death->work.entry, &thread->todo);
} else {
list_add_tail(&death->work.entry, &proc->todo);
--
2.7.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: android: binder: fixed line over 80 caracters
2016-03-12 23:40 [PATCH] staging: android: binder: fixed line over 80 caracters Juliana Rodrigues
@ 2016-03-13 0:28 ` Greg KH
2016-03-13 0:29 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-03-13 0:28 UTC (permalink / raw)
To: Juliana Rodrigues; +Cc: outreachy-kernel
On Sat, Mar 12, 2016 at 08:40:07PM -0300, Juliana Rodrigues wrote:
> This patch fixes the following warning caused by checkpatch.pl:
>
> WARNING: line over 80 characters
> + if (thread->looper & (BINDER_LOOPER_STATE_REGISTERED | BINDER_LOOPER_STATE_ENTERED)) {
>
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
> drivers/android/binder.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 7d00b7a..94190fc 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -2054,7 +2054,9 @@ static int binder_thread_write(struct binder_proc *proc,
> ref->death = NULL;
> if (list_empty(&death->work.entry)) {
> death->work.type = BINDER_WORK_CLEAR_DEATH_NOTIFICATION;
> - if (thread->looper & (BINDER_LOOPER_STATE_REGISTERED | BINDER_LOOPER_STATE_ENTERED)) {
> + if (thread->looper & (
> + BINDER_LOOPER_STATE_REGISTERED |
> + BINDER_LOOPER_STATE_ENTERED)) {
Please put the original ( on the second line, and don't use a full tab
to indent, that just looks confusing now, don't you agree? Line it up
under the first character in "thread->".
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: android: binder: fixed line over 80 caracters
2016-03-12 23:40 [PATCH] staging: android: binder: fixed line over 80 caracters Juliana Rodrigues
2016-03-13 0:28 ` [Outreachy kernel] " Greg KH
@ 2016-03-13 0:29 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-03-13 0:29 UTC (permalink / raw)
To: Juliana Rodrigues; +Cc: outreachy-kernel
On Sat, Mar 12, 2016 at 08:40:07PM -0300, Juliana Rodrigues wrote:
> This patch fixes the following warning caused by checkpatch.pl:
>
> WARNING: line over 80 characters
> + if (thread->looper & (BINDER_LOOPER_STATE_REGISTERED | BINDER_LOOPER_STATE_ENTERED)) {
>
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
> drivers/android/binder.c | 4 +++-
Same comment here about not being in drivers/staging :(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-13 0:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-12 23:40 [PATCH] staging: android: binder: fixed line over 80 caracters Juliana Rodrigues
2016-03-13 0:28 ` [Outreachy kernel] " Greg KH
2016-03-13 0:29 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.