All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: android: binder: fixed checkpatch warning
@ 2016-03-12 22:39 Juliana Rodrigues
  2016-03-13  0:29 ` [Outreachy kernel] " Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Juliana Rodrigues @ 2016-03-12 22:39 UTC (permalink / raw)
  To: outreachy-kernel

A comment was not properly formatted, causing warnings when running checkpatch.pl.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
---
 drivers/android/binder.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 16288e7..9d109f7 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2741,8 +2741,9 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 	unsigned int size = _IOC_SIZE(cmd);
 	void __user *ubuf = (void __user *)arg;
 
-	/*pr_info("binder_ioctl: %d:%d %x %lx\n",
-			proc->pid, current->pid, cmd, arg);*/
+	/* pr_info("binder_ioctl: %d:%d %x %lx\n",
+	 *		proc->pid, current->pid, cmd, arg);
+	 */
 
 	if (unlikely(current->mm != proc->vma_vm_mm)) {
 		pr_err("current mm mismatch proc mm\n");
@@ -2930,8 +2931,9 @@ static int binder_mmap(struct file *filp, struct vm_area_struct *vma)
 	proc->vma = vma;
 	proc->vma_vm_mm = vma->vm_mm;
 
-	/*pr_info("binder_mmap: %d %lx-%lx maps %p\n",
-		 proc->pid, vma->vm_start, vma->vm_end, proc->buffer);*/
+	/* pr_info("binder_mmap: %d %lx-%lx maps %p\n",
+	 *	 proc->pid, vma->vm_start, vma->vm_end, proc->buffer);
+	 */
 	return 0;
 
 err_alloc_small_buf_failed:
-- 
2.7.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: android: binder: fixed checkpatch warning
  2016-03-12 22:39 [PATCH] staging: android: binder: fixed checkpatch warning Juliana Rodrigues
@ 2016-03-13  0:29 ` Greg KH
  2016-03-13  0:55   ` Juliana Rodrigues
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2016-03-13  0:29 UTC (permalink / raw)
  To: Juliana Rodrigues; +Cc: outreachy-kernel

On Sat, Mar 12, 2016 at 07:39:13PM -0300, Juliana Rodrigues wrote:
> A comment was not properly formatted, causing warnings when running checkpatch.pl.
> 
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
>  drivers/android/binder.c | 10 ++++++----

I can't take outreachy patches for anything outside of drivers/staging/
why are you making changes in drivers/android?

sorry,

greg k-h


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: android: binder: fixed checkpatch warning
  2016-03-13  0:29 ` [Outreachy kernel] " Greg KH
@ 2016-03-13  0:55   ` Juliana Rodrigues
  0 siblings, 0 replies; 3+ messages in thread
From: Juliana Rodrigues @ 2016-03-13  0:55 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: juliana.orod


[-- Attachment #1.1: Type: text/plain, Size: 566 bytes --]

oh sorry, i didnt know ): 

Em sábado, 12 de março de 2016 21:45:24 UTC-3, gregkh escreveu:
>
> On Sat, Mar 12, 2016 at 07:39:13PM -0300, Juliana Rodrigues wrote: 
> > A comment was not properly formatted, causing warnings when running 
> checkpatch.pl. 
> > 
> > Signed-off-by: Juliana Rodrigues <julian...@gmail.com <javascript:>> 
> > --- 
> >  drivers/android/binder.c | 10 ++++++---- 
>
> I can't take outreachy patches for anything outside of drivers/staging/ 
> why are you making changes in drivers/android? 
>
> sorry, 
>
> greg k-h 
>

[-- Attachment #1.2: Type: text/html, Size: 1348 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-03-13  0:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-12 22:39 [PATCH] staging: android: binder: fixed checkpatch warning Juliana Rodrigues
2016-03-13  0:29 ` [Outreachy kernel] " Greg KH
2016-03-13  0:55   ` Juliana Rodrigues

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.