From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] bus: imx-weim: Take the 'status' property value into account
Date: Sat, 12 Mar 2016 17:08:49 -0800 [thread overview]
Message-ID: <20160313010849.GI17502@localhost> (raw)
In-Reply-To: <20160229033649.GS22051@tiger>
On Mon, Feb 29, 2016 at 11:36:49AM +0800, Shawn Guo wrote:
> On Mon, Feb 22, 2016 at 09:01:53AM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@nxp.com>
> >
> > Currently we have an incorrect behaviour when multiple devices
> > are present under the weim node. For example:
> >
> > &weim {
> > ...
> > status = "okay";
> >
> > sram at 0,0 {
> > ...
> > status = "okay";
> > };
> >
> > mram at 0,0 {
> > ...
> > status = "disabled";
> > };
> > };
> >
> > In this case only the 'sram' device should be probed and not 'mram'.
> >
> > However what happens currently is that the status variable is ignored,
> > causing the 'sram' device to be disabled and 'mram' to be enabled.
> >
> > Change the weim_parse_dt() function to use
> > for_each_available_child_of_node()so that the devices marked with
> > 'status = disabled' are not probed.
> >
> > Cc: <stable@vger.kernel.org>
> > Suggested-by: Wolfgang Netbal <wolfgang.netbal@sigmatek.at>
> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>
> Acked-by: Shawn Guo <shawnguo@kernel.org>
>
> Arnd, Olof,
>
> I do not have any other 'driver' patches queued, so please help directly
> apply this one. Considering this fixes a real problem, it would be good
> if we can merge this through -rc. But we understand that it's -rc6 now,
> and this doesn't fix a regression or so-critical issue, so it should be
> fine to queue the patch for the next release as well.
Sorry for the high latency here, I had missed this patch and noticed now when
I did a sweep. I've merged it into next/drivers for 4.6.
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: Olof Johansson <olof@lixom.net>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>,
arm@kernel.org, s.hauer@pengutronix.de,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
wolfgang.netbal@sigmatek.at,
Fabio Estevam <fabio.estevam@nxp.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] bus: imx-weim: Take the 'status' property value into account
Date: Sat, 12 Mar 2016 17:08:49 -0800 [thread overview]
Message-ID: <20160313010849.GI17502@localhost> (raw)
In-Reply-To: <20160229033649.GS22051@tiger>
On Mon, Feb 29, 2016 at 11:36:49AM +0800, Shawn Guo wrote:
> On Mon, Feb 22, 2016 at 09:01:53AM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@nxp.com>
> >
> > Currently we have an incorrect behaviour when multiple devices
> > are present under the weim node. For example:
> >
> > &weim {
> > ...
> > status = "okay";
> >
> > sram@0,0 {
> > ...
> > status = "okay";
> > };
> >
> > mram@0,0 {
> > ...
> > status = "disabled";
> > };
> > };
> >
> > In this case only the 'sram' device should be probed and not 'mram'.
> >
> > However what happens currently is that the status variable is ignored,
> > causing the 'sram' device to be disabled and 'mram' to be enabled.
> >
> > Change the weim_parse_dt() function to use
> > for_each_available_child_of_node()so that the devices marked with
> > 'status = disabled' are not probed.
> >
> > Cc: <stable@vger.kernel.org>
> > Suggested-by: Wolfgang Netbal <wolfgang.netbal@sigmatek.at>
> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>
> Acked-by: Shawn Guo <shawnguo@kernel.org>
>
> Arnd, Olof,
>
> I do not have any other 'driver' patches queued, so please help directly
> apply this one. Considering this fixes a real problem, it would be good
> if we can merge this through -rc. But we understand that it's -rc6 now,
> and this doesn't fix a regression or so-critical issue, so it should be
> fine to queue the patch for the next release as well.
Sorry for the high latency here, I had missed this patch and noticed now when
I did a sweep. I've merged it into next/drivers for 4.6.
-Olof
next prev parent reply other threads:[~2016-03-13 1:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 12:01 [PATCH] bus: imx-weim: Take the 'status' property value into account Fabio Estevam
2016-02-22 12:01 ` Fabio Estevam
2016-02-23 8:57 ` Sascha Hauer
2016-02-23 8:57 ` Sascha Hauer
2016-02-29 3:36 ` Shawn Guo
2016-02-29 3:36 ` Shawn Guo
2016-03-13 1:08 ` Olof Johansson [this message]
2016-03-13 1:08 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160313010849.GI17502@localhost \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.