[PATCH] staging: dgnc: replaces udelay with usleep_range in dgnc_cls.c

[PATCH] staging: dgnc: replaces udelay with usleep_range in dgnc_cls.c

[Juliana Rodrigues]

This patch fixes the following issue on checkpatch.pl:

CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
+       udelay(10);

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
---
 drivers/staging/dgnc/dgnc_cls.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index 6e1e475..ac6f7cd 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -1172,7 +1172,8 @@ static void cls_uart_init(struct channel_t *ch)
 		UART_FCR_CLEAR_RCVR  |
 		UART_FCR_CLEAR_XMIT),
 		&ch->ch_cls_uart->isr_fcr);
-	udelay(10);
+
+	usleep_range(10000, 11000);
 
 	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
 
-- 
2.7.2

Re: [Outreachy kernel] [PATCH] staging: dgnc: replaces udelay with usleep_range in dgnc_cls.c

[Julia Lawall]

On Sat, 12 Mar 2016, Juliana Rodrigues wrote:

> This patch fixes the following issue on checkpatch.pl:
> 
> CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
> +       udelay(10);
> 
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_cls.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 6e1e475..ac6f7cd 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -1172,7 +1172,8 @@ static void cls_uart_init(struct channel_t *ch)
>  		UART_FCR_CLEAR_RCVR  |
>  		UART_FCR_CLEAR_XMIT),
>  		&ch->ch_cls_uart->isr_fcr);
> -	udelay(10);
> +

Why the blank line?

julia

> +	usleep_range(10000, 11000);
>  
>  	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
>  
> -- 
> 2.7.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160313014216.GA20292%40spock.
> For more options, visit https://groups.google.com/d/optout.
>