* [PATCH v2] staging: dgnc: fixed multiple blank lines
@ 2016-03-13 4:05 Juliana Rodrigues
2016-03-13 4:12 ` [Outreachy kernel] " Julia Lawall
2016-03-21 21:01 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Juliana Rodrigues @ 2016-03-13 4:05 UTC (permalink / raw)
To: outreachy-kernel
This patch removes multiple blank lines that caused
checkpatch issues.
Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
---
Changes in v2:
- Removed file name from subject line.
drivers/staging/dgnc/dgnc_driver.h | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
index 6d91abd..d76f91e 100644
--- a/drivers/staging/dgnc/dgnc_driver.h
+++ b/drivers/staging/dgnc/dgnc_driver.h
@@ -88,7 +88,6 @@
#define _POSIX_VDISABLE '\0'
#endif
-
/*
* All the possible states the driver can be while being loaded.
*/
@@ -106,7 +105,6 @@ enum {
BOARD_READY
};
-
/*************************************************************************
*
* Structures and closely related defines.
@@ -145,7 +143,6 @@ struct board_ops {
************************************************************************/
#define BD_IS_PCI_EXPRESS 0x0001 /* Is a PCI Express board */
-
/*
* Per-board information
*/
@@ -241,7 +238,6 @@ struct dgnc_board {
};
-
/************************************************************************
* Unit flag definitions for un_flags.
************************************************************************/
@@ -277,7 +273,6 @@ struct un_t {
struct device *un_sysfs;
};
-
/************************************************************************
* Device flag definitions for ch_flags.
************************************************************************/
@@ -300,7 +295,6 @@ struct un_t {
#define CH_FORCED_STOP 0x20000 /* Output is forcibly stopped */
#define CH_FORCED_STOPI 0x40000 /* Input is forcibly stopped */
-
/* Our Read/Error/Write queue sizes */
#define RQUEUEMASK 0x1FFF /* 8 K - 1 */
#define EQUEUEMASK 0x1FFF /* 8 K - 1 */
@@ -309,7 +303,6 @@ struct un_t {
#define EQUEUESIZE RQUEUESIZE
#define WQUEUESIZE (WQUEUEMASK + 1)
-
/************************************************************************
* Channel information structure.
************************************************************************/
@@ -397,7 +390,6 @@ struct channel_t {
ulong ch_intr_tx; /* Count of interrupts */
ulong ch_intr_rx; /* Count of interrupts */
-
/* /proc/<board>/<channel> entries */
struct proc_dir_entry *proc_entry_pointer;
struct dgnc_proc_entry *dgnc_channel_table;
@@ -415,5 +407,4 @@ extern uint dgnc_NumBoards; /* Total number of boards */
extern struct dgnc_board *dgnc_Board[MAXBOARDS]; /* Array of board
* structs
*/
-
#endif
--
2.7.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: dgnc: fixed multiple blank lines
2016-03-13 4:05 [PATCH v2] staging: dgnc: fixed multiple blank lines Juliana Rodrigues
@ 2016-03-13 4:12 ` Julia Lawall
2016-03-21 21:01 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2016-03-13 4:12 UTC (permalink / raw)
To: Juliana Rodrigues; +Cc: outreachy-kernel
On Sun, 13 Mar 2016, Juliana Rodrigues wrote:
> This patch removes multiple blank lines that caused
> checkpatch issues.
Looks better, thanks. Still you can approach 80 characters for the commit
message. You should be using an editor to write your commit messages that
inserts a newline in the right place, so you don't have to think about
this issue.
julia
>
>
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
> Changes in v2:
> - Removed file name from subject line.
>
> drivers/staging/dgnc/dgnc_driver.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index 6d91abd..d76f91e 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -88,7 +88,6 @@
> #define _POSIX_VDISABLE '\0'
> #endif
>
> -
> /*
> * All the possible states the driver can be while being loaded.
> */
> @@ -106,7 +105,6 @@ enum {
> BOARD_READY
> };
>
> -
> /*************************************************************************
> *
> * Structures and closely related defines.
> @@ -145,7 +143,6 @@ struct board_ops {
> ************************************************************************/
> #define BD_IS_PCI_EXPRESS 0x0001 /* Is a PCI Express board */
>
> -
> /*
> * Per-board information
> */
> @@ -241,7 +238,6 @@ struct dgnc_board {
>
> };
>
> -
> /************************************************************************
> * Unit flag definitions for un_flags.
> ************************************************************************/
> @@ -277,7 +273,6 @@ struct un_t {
> struct device *un_sysfs;
> };
>
> -
> /************************************************************************
> * Device flag definitions for ch_flags.
> ************************************************************************/
> @@ -300,7 +295,6 @@ struct un_t {
> #define CH_FORCED_STOP 0x20000 /* Output is forcibly stopped */
> #define CH_FORCED_STOPI 0x40000 /* Input is forcibly stopped */
>
> -
> /* Our Read/Error/Write queue sizes */
> #define RQUEUEMASK 0x1FFF /* 8 K - 1 */
> #define EQUEUEMASK 0x1FFF /* 8 K - 1 */
> @@ -309,7 +303,6 @@ struct un_t {
> #define EQUEUESIZE RQUEUESIZE
> #define WQUEUESIZE (WQUEUEMASK + 1)
>
> -
> /************************************************************************
> * Channel information structure.
> ************************************************************************/
> @@ -397,7 +390,6 @@ struct channel_t {
> ulong ch_intr_tx; /* Count of interrupts */
> ulong ch_intr_rx; /* Count of interrupts */
>
> -
> /* /proc/<board>/<channel> entries */
> struct proc_dir_entry *proc_entry_pointer;
> struct dgnc_proc_entry *dgnc_channel_table;
> @@ -415,5 +407,4 @@ extern uint dgnc_NumBoards; /* Total number of boards */
> extern struct dgnc_board *dgnc_Board[MAXBOARDS]; /* Array of board
> * structs
> */
> -
> #endif
> --
> 2.7.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160313040529.GA10236%40spock.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: dgnc: fixed multiple blank lines
2016-03-13 4:05 [PATCH v2] staging: dgnc: fixed multiple blank lines Juliana Rodrigues
2016-03-13 4:12 ` [Outreachy kernel] " Julia Lawall
@ 2016-03-21 21:01 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-03-21 21:01 UTC (permalink / raw)
To: Juliana Rodrigues; +Cc: outreachy-kernel
On Sun, Mar 13, 2016 at 01:05:29AM -0300, Juliana Rodrigues wrote:
> This patch removes multiple blank lines that caused
> checkpatch issues.
>
>
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
> Changes in v2:
> - Removed file name from subject line.
You have sent a lot of different patches for this same driver, some in
series, some not. So I don't know what order to apply which in. Some
also depend on other patches. I'm totally confused. Please resend all
patches you have made for this driver, in one series, in the needed
order as I've flushed all of your pending patches for this driver from
my todo queue now.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-21 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-13 4:05 [PATCH v2] staging: dgnc: fixed multiple blank lines Juliana Rodrigues
2016-03-13 4:12 ` [Outreachy kernel] " Julia Lawall
2016-03-21 21:01 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.