[PATCH v2] staging: dgnc: replaced udelay with usleep_range

[PATCH v2] staging: dgnc: replaced udelay with usleep_range

[Juliana Rodrigues]

This patch replaces udelay with usleep_range fixing
a checkpatch.pl issue:

CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
+       udelay(10);

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
---
Changes in v2:
   - Fixed range timing
 
 drivers/staging/dgnc/dgnc_cls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index 51db98b..7e3cc48 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -956,7 +956,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
 	 * Presumably, this is a bug in this UART.
 	 */
 
-	usleep_range(10000, 11000);
+	usleep_range(10, 20);
 }
 
 static void cls_copy_data_from_queue_to_uart(struct channel_t *ch)
-- 
2.7.2

Re: [Outreachy kernel] [PATCH v2] staging: dgnc: replaced udelay with usleep_range

[Julia Lawall]

On Sun, 13 Mar 2016, Juliana Rodrigues wrote:

> This patch replaces udelay with usleep_range fixing
> a checkpatch.pl issue:
> 
> CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
> +       udelay(10);
> 
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
> Changes in v2:
>    - Fixed range timing
>  
>  drivers/staging/dgnc/dgnc_cls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 51db98b..7e3cc48 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -956,7 +956,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
>  	 * Presumably, this is a bug in this UART.
>  	 */
>  
> -	usleep_range(10000, 11000);
> +	usleep_range(10, 20);

It still doesn't say why you chose this value.

julia

>  }
>  
>  static void cls_copy_data_from_queue_to_uart(struct channel_t *ch)
> -- 
> 2.7.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160313123337.GA10274%40spock.
> For more options, visit https://groups.google.com/d/optout.
> 

Re: [Outreachy kernel] [PATCH v2] staging: dgnc: replaced udelay with usleep_range

[Greg KH]

On Sun, Mar 13, 2016 at 09:33:37AM -0300, Juliana Rodrigues wrote:
> This patch replaces udelay with usleep_range fixing
> a checkpatch.pl issue:
> 
> CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
> +       udelay(10);
> 
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
> Changes in v2:
>    - Fixed range timing
>  
>  drivers/staging/dgnc/dgnc_cls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
> index 51db98b..7e3cc48 100644
> --- a/drivers/staging/dgnc/dgnc_cls.c
> +++ b/drivers/staging/dgnc/dgnc_cls.c
> @@ -956,7 +956,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
>  	 * Presumably, this is a bug in this UART.
>  	 */
>  
> -	usleep_range(10000, 11000);
> +	usleep_range(10, 20);

Your subject does not match this patch :(