From: Al Viro <viro@ZenIV.linux.org.uk>
To: lkp@lists.01.org
Subject: Re: [namei] fda89e6574: kernel BUG at fs/namei.c:679!
Date: Mon, 14 Mar 2016 00:57:06 +0000 [thread overview]
Message-ID: <20160314005706.GX17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <871t7dhokl.fsf@yhuang-dev.intel.com>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Mon, Mar 14, 2016 at 08:48:26AM +0800, kernel test robot wrote:
> FYI, we noticed the below changes on
>
> https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.lookups
> commit fda89e65743179d09e55bc6c265d06fa5efa8803 ("namei: untanlge lookup_fast()")
Could you check if the diff below fixes it?
diff --git a/fs/namei.c b/fs/namei.c
index 35b10fa..428a34f 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1563,6 +1563,7 @@ static int lookup_fast(struct nameidata *nd,
dput(dentry);
return status;
}
+ goto l;
}
}
/*
@@ -1590,6 +1591,7 @@ static int lookup_fast(struct nameidata *nd,
return status;
}
}
+l:
if (unlikely(d_is_negative(dentry))) {
dput(dentry);
return -ENOENT;
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: kernel test robot <ying.huang@linux.intel.com>
Cc: lkp@01.org, LKML <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [lkp] [namei] fda89e6574: kernel BUG at fs/namei.c:679!
Date: Mon, 14 Mar 2016 00:57:06 +0000 [thread overview]
Message-ID: <20160314005706.GX17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <871t7dhokl.fsf@yhuang-dev.intel.com>
On Mon, Mar 14, 2016 at 08:48:26AM +0800, kernel test robot wrote:
> FYI, we noticed the below changes on
>
> https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.lookups
> commit fda89e65743179d09e55bc6c265d06fa5efa8803 ("namei: untanlge lookup_fast()")
Could you check if the diff below fixes it?
diff --git a/fs/namei.c b/fs/namei.c
index 35b10fa..428a34f 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1563,6 +1563,7 @@ static int lookup_fast(struct nameidata *nd,
dput(dentry);
return status;
}
+ goto l;
}
}
/*
@@ -1590,6 +1591,7 @@ static int lookup_fast(struct nameidata *nd,
return status;
}
}
+l:
if (unlikely(d_is_negative(dentry))) {
dput(dentry);
return -ENOENT;
next prev parent reply other threads:[~2016-03-14 0:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 0:48 [namei] fda89e6574: kernel BUG at fs/namei.c:679! kernel test robot
2016-03-14 0:48 ` [lkp] " kernel test robot
2016-03-14 0:57 ` Al Viro [this message]
2016-03-14 0:57 ` Al Viro
2016-03-14 3:10 ` Al Viro
2016-03-14 3:10 ` [lkp] " Al Viro
2016-03-14 5:30 ` Huang, Ying
2016-03-14 5:30 ` [LKP] [lkp] " Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314005706.GX17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.