From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org,
igor.rubinov@gmail.com, alex.bennee@linaro.org,
mark.burton@greensocs.com, real@ispras.ru, hines@cert.org,
batuzovk@ispras.ru, maria.klimushenkova@ispras.ru,
pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, kwolf@redhat.com,
stefanha@redhat.com, fred.konrad@greensocs.com
Subject: [Qemu-devel] [PATCH v5 4/7] block: add flush callback
Date: Mon, 14 Mar 2016 10:44:53 +0300 [thread overview]
Message-ID: <20160314074453.4980.68514.stgit@PASHA-ISP> (raw)
In-Reply-To: <20160314074429.4980.34777.stgit@PASHA-ISP>
This patch adds callback for flush request. This callback is responsible
for flushing whole block devices stack. bdrv_flush function does not
proceed to underlying devices. It should be performed by this callback
function, if needed.
Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
block/io.c | 7 +++++++
include/block/block_int.h | 7 +++++++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/block/io.c b/block/io.c
index a69bfc4..242ee0c 100644
--- a/block/io.c
+++ b/block/io.c
@@ -2369,6 +2369,13 @@ int coroutine_fn bdrv_co_flush(BlockDriverState *bs)
}
tracked_request_begin(&req, bs, 0, 0, BDRV_TRACKED_FLUSH);
+
+ /* Write back all layers by calling one driver function */
+ if (bs->drv->bdrv_co_flush) {
+ ret = bs->drv->bdrv_co_flush(bs);
+ goto out;
+ }
+
/* Write back cached data to the OS even with cache=unsafe */
BLKDBG_EVENT(bs->file, BLKDBG_FLUSH_TO_OS);
if (bs->drv->bdrv_co_flush_to_os) {
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 9ef823a..8f72037 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -176,6 +176,13 @@ struct BlockDriver {
int (*bdrv_inactivate)(BlockDriverState *bs);
/*
+ * Flushes all data for all layers by calling bdrv_co_flush for underlying
+ * layers, if needed. This function is needed for deterministic
+ * synchronization of the flush finishing callback.
+ */
+ int coroutine_fn (*bdrv_co_flush)(BlockDriverState *bs);
+
+ /*
* Flushes all data that was already written to the OS all the way down to
* the disk (for example raw-posix calls fsync()).
*/
next prev parent reply other threads:[~2016-03-14 7:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 7:44 [Qemu-devel] [PATCH v5 0/7] Deterministic replay extensions Pavel Dovgalyuk
2016-03-14 7:44 ` [Qemu-devel] [PATCH v5 1/7] replay: character devices Pavel Dovgalyuk
2016-03-14 14:11 ` Paolo Bonzini
2016-03-23 15:45 ` Kevin Wolf
2016-03-23 16:54 ` Paolo Bonzini
2016-03-14 7:44 ` [Qemu-devel] [PATCH v5 2/7] icount: remove obsolete warp call Pavel Dovgalyuk
2016-03-14 7:44 ` [Qemu-devel] [PATCH v5 3/7] icount: decouple warp calls Pavel Dovgalyuk
2016-03-14 7:44 ` Pavel Dovgalyuk [this message]
2016-03-23 15:46 ` [Qemu-devel] [PATCH v5 4/7] block: add flush callback Kevin Wolf
2016-03-14 7:44 ` [Qemu-devel] [PATCH v5 5/7] replay: bh scheduling fix Pavel Dovgalyuk
2016-03-14 7:45 ` [Qemu-devel] [PATCH v5 6/7] replay: fix error message Pavel Dovgalyuk
2016-03-24 11:56 ` Kevin Wolf
2016-03-14 7:45 ` [Qemu-devel] [PATCH v5 7/7] replay: introduce block devices record/replay Pavel Dovgalyuk
2016-03-23 15:52 ` Kevin Wolf
2016-03-15 20:04 ` [Qemu-devel] [PATCH v5 0/7] Deterministic replay extensions Igor R
2016-03-17 8:06 ` Pavel Dovgalyuk
2016-03-24 11:59 ` Kevin Wolf
2016-03-24 19:24 ` Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314074453.4980.68514.stgit@PASHA-ISP \
--to=pavel.dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=batuzovk@ispras.ru \
--cc=edgar.iglesias@xilinx.com \
--cc=fred.konrad@greensocs.com \
--cc=hines@cert.org \
--cc=igor.rubinov@gmail.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mark.burton@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=real@ispras.ru \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.