All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org,
	igor.rubinov@gmail.com, alex.bennee@linaro.org,
	mark.burton@greensocs.com, real@ispras.ru, hines@cert.org,
	batuzovk@ispras.ru, maria.klimushenkova@ispras.ru,
	pavel.dovgaluk@ispras.ru, pbonzini@redhat.com, kwolf@redhat.com,
	stefanha@redhat.com, fred.konrad@greensocs.com
Subject: [Qemu-devel] [PATCH v5 5/7] replay: bh scheduling fix
Date: Mon, 14 Mar 2016 10:44:59 +0300	[thread overview]
Message-ID: <20160314074459.4980.20779.stgit@PASHA-ISP> (raw)
In-Reply-To: <20160314074429.4980.34777.stgit@PASHA-ISP>

This patch fixes scheduling of bottom halves when record/replay is enabled.
Now BH are not added to replay queue when asynchronous events are disabled.
This may happen in startup and loadvm/savevm phases of execution.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 replay/replay-events.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/replay/replay-events.c b/replay/replay-events.c
index ca940f7..4aa8034 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -135,7 +135,7 @@ void replay_add_event(ReplayAsyncEventKind event_kind,
 
 void replay_bh_schedule_event(QEMUBH *bh)
 {
-    if (replay_mode != REPLAY_MODE_NONE) {
+    if (replay_mode != REPLAY_MODE_NONE && events_enabled) {
         uint64_t id = replay_get_current_step();
         replay_add_event(REPLAY_ASYNC_EVENT_BH, bh, NULL, id);
     } else {

  parent reply	other threads:[~2016-03-14  7:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14  7:44 [Qemu-devel] [PATCH v5 0/7] Deterministic replay extensions Pavel Dovgalyuk
2016-03-14  7:44 ` [Qemu-devel] [PATCH v5 1/7] replay: character devices Pavel Dovgalyuk
2016-03-14 14:11   ` Paolo Bonzini
2016-03-23 15:45   ` Kevin Wolf
2016-03-23 16:54     ` Paolo Bonzini
2016-03-14  7:44 ` [Qemu-devel] [PATCH v5 2/7] icount: remove obsolete warp call Pavel Dovgalyuk
2016-03-14  7:44 ` [Qemu-devel] [PATCH v5 3/7] icount: decouple warp calls Pavel Dovgalyuk
2016-03-14  7:44 ` [Qemu-devel] [PATCH v5 4/7] block: add flush callback Pavel Dovgalyuk
2016-03-23 15:46   ` Kevin Wolf
2016-03-14  7:44 ` Pavel Dovgalyuk [this message]
2016-03-14  7:45 ` [Qemu-devel] [PATCH v5 6/7] replay: fix error message Pavel Dovgalyuk
2016-03-24 11:56   ` Kevin Wolf
2016-03-14  7:45 ` [Qemu-devel] [PATCH v5 7/7] replay: introduce block devices record/replay Pavel Dovgalyuk
2016-03-23 15:52   ` Kevin Wolf
2016-03-15 20:04 ` [Qemu-devel] [PATCH v5 0/7] Deterministic replay extensions Igor R
2016-03-17  8:06   ` Pavel Dovgalyuk
2016-03-24 11:59 ` Kevin Wolf
2016-03-24 19:24   ` Pavel Dovgalyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160314074459.4980.20779.stgit@PASHA-ISP \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=alex.bennee@linaro.org \
    --cc=batuzovk@ispras.ru \
    --cc=edgar.iglesias@xilinx.com \
    --cc=fred.konrad@greensocs.com \
    --cc=hines@cert.org \
    --cc=igor.rubinov@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=maria.klimushenkova@ispras.ru \
    --cc=mark.burton@greensocs.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=real@ispras.ru \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.