* [PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y @ 2016-03-12 12:50 ` Andy Yan 0 siblings, 0 replies; 8+ messages in thread From: Andy Yan @ 2016-03-12 12:50 UTC (permalink / raw) To: linux-arm-kernel All the current rk3066 based boards use pwm modulate vdd_logic voltage, the board may hang when the system boot and run to a higher frequency without pwm enabled, so enable it as builtin. Signed-off-by: Andy Yan <andy.yan@kernel-upstream.org> --- arch/arm/configs/multi_v7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 8e8b2ac..94639b1 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -757,7 +757,7 @@ CONFIG_PWM_ATMEL=m CONFIG_PWM_ATMEL_TCB=m CONFIG_PWM_FSL_FTM=m CONFIG_PWM_RENESAS_TPU=y -CONFIG_PWM_ROCKCHIP=m +CONFIG_PWM_ROCKCHIP=y CONFIG_PWM_SAMSUNG=m CONFIG_PWM_SUN4I=y CONFIG_PWM_TEGRA=y -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y @ 2016-03-12 12:50 ` Andy Yan 0 siblings, 0 replies; 8+ messages in thread From: Andy Yan @ 2016-03-12 12:50 UTC (permalink / raw) To: arnd Cc: javier, kgene, k.kozlowski, treding, geert+renesas, linux-kernel, public_timo.s, linux, alexandre.belloni, sjoerd.simons, olof, linux-arm-kernel, Andy Yan All the current rk3066 based boards use pwm modulate vdd_logic voltage, the board may hang when the system boot and run to a higher frequency without pwm enabled, so enable it as builtin. Signed-off-by: Andy Yan <andy.yan@kernel-upstream.org> --- arch/arm/configs/multi_v7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 8e8b2ac..94639b1 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -757,7 +757,7 @@ CONFIG_PWM_ATMEL=m CONFIG_PWM_ATMEL_TCB=m CONFIG_PWM_FSL_FTM=m CONFIG_PWM_RENESAS_TPU=y -CONFIG_PWM_ROCKCHIP=m +CONFIG_PWM_ROCKCHIP=y CONFIG_PWM_SAMSUNG=m CONFIG_PWM_SUN4I=y CONFIG_PWM_TEGRA=y -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y 2016-03-12 12:50 ` Andy Yan @ 2016-03-12 12:51 ` Andy Yan -1 siblings, 0 replies; 8+ messages in thread From: Andy Yan @ 2016-03-12 12:51 UTC (permalink / raw) To: linux-arm-kernel Some platform like Rockchip rk3066 use pwm as a regulator to modulate cpu voltage, so pwm regulator should be enabled at system boot time if the system want to run with high frequency. Signed-off-by: Andy Yan <andy.yan@kernel-upstream.org> --- arch/arm/configs/multi_v7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 94639b1..e0178f2 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -477,7 +477,7 @@ CONFIG_REGULATOR_MAX77693=m CONFIG_REGULATOR_MAX77802=m CONFIG_REGULATOR_PALMAS=y CONFIG_REGULATOR_PBIAS=y -CONFIG_REGULATOR_PWM=m +CONFIG_REGULATOR_PWM=y CONFIG_REGULATOR_QCOM_RPM=y CONFIG_REGULATOR_QCOM_SMD_RPM=y CONFIG_REGULATOR_S2MPS11=y -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y @ 2016-03-12 12:51 ` Andy Yan 0 siblings, 0 replies; 8+ messages in thread From: Andy Yan @ 2016-03-12 12:51 UTC (permalink / raw) To: arnd Cc: javier, kgene, k.kozlowski, treding, geert+renesas, linux-kernel, public_timo.s, linux, alexandre.belloni, sjoerd.simons, olof, linux-arm-kernel, Andy Yan Some platform like Rockchip rk3066 use pwm as a regulator to modulate cpu voltage, so pwm regulator should be enabled at system boot time if the system want to run with high frequency. Signed-off-by: Andy Yan <andy.yan@kernel-upstream.org> --- arch/arm/configs/multi_v7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 94639b1..e0178f2 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -477,7 +477,7 @@ CONFIG_REGULATOR_MAX77693=m CONFIG_REGULATOR_MAX77802=m CONFIG_REGULATOR_PALMAS=y CONFIG_REGULATOR_PBIAS=y -CONFIG_REGULATOR_PWM=m +CONFIG_REGULATOR_PWM=y CONFIG_REGULATOR_QCOM_RPM=y CONFIG_REGULATOR_QCOM_SMD_RPM=y CONFIG_REGULATOR_S2MPS11=y -- 1.9.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y 2016-03-12 12:51 ` Andy Yan @ 2016-03-14 12:21 ` Thierry Reding -1 siblings, 0 replies; 8+ messages in thread From: Thierry Reding @ 2016-03-14 12:21 UTC (permalink / raw) To: linux-arm-kernel On Sat, Mar 12, 2016 at 08:51:40PM +0800, Andy Yan wrote: > Some platform like Rockchip rk3066 use pwm as a regulator to modulate > cpu voltage, so pwm regulator should be enabled at system boot time if > the system want to run with high frequency. > > Signed-off-by: Andy Yan <andy.yan@kernel-upstream.org> > --- > > arch/arm/configs/multi_v7_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This really belongs in patch 1/2. But then the same comments hold true and I think you'll need to come up with a proper fix that prevents the switch to a higher frequency if don't have the necessary regulator, or make the Kconfig symbol bool if all else fails. If you make the Kconfig symbol bool I'd expect a really good explanation in the commit message as to why it can't be fixed properly. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160314/e687abb1/attachment.sig> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y @ 2016-03-14 12:21 ` Thierry Reding 0 siblings, 0 replies; 8+ messages in thread From: Thierry Reding @ 2016-03-14 12:21 UTC (permalink / raw) To: Andy Yan Cc: arnd, javier, kgene, k.kozlowski, geert+renesas, linux-kernel, public_timo.s, linux, alexandre.belloni, sjoerd.simons, olof, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 838 bytes --] On Sat, Mar 12, 2016 at 08:51:40PM +0800, Andy Yan wrote: > Some platform like Rockchip rk3066 use pwm as a regulator to modulate > cpu voltage, so pwm regulator should be enabled at system boot time if > the system want to run with high frequency. > > Signed-off-by: Andy Yan <andy.yan@kernel-upstream.org> > --- > > arch/arm/configs/multi_v7_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This really belongs in patch 1/2. But then the same comments hold true and I think you'll need to come up with a proper fix that prevents the switch to a higher frequency if don't have the necessary regulator, or make the Kconfig symbol bool if all else fails. If you make the Kconfig symbol bool I'd expect a really good explanation in the commit message as to why it can't be fixed properly. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y 2016-03-12 12:50 ` Andy Yan @ 2016-03-14 12:18 ` Thierry Reding -1 siblings, 0 replies; 8+ messages in thread From: Thierry Reding @ 2016-03-14 12:18 UTC (permalink / raw) To: linux-arm-kernel On Sat, Mar 12, 2016 at 08:50:29PM +0800, Andy Yan wrote: > All the current rk3066 based boards use pwm modulate vdd_logic > voltage, the board may hang when the system boot and run to a higher > frequency without pwm enabled, so enable it as builtin. I don't understand the rationale here. Surely if the system can't safely switch to a higher frequency because the regulator isn't available, then it should be prevented from switching, shouldn't it? Making this change alone will not prevent users from switching this back to =m on their own. So either you need to add code to prevent a switch to an unsupported frequency in the absence of the regulator, or you need to change the PWM_ROCKCHIP Kconfig option to be bool instead, though the latter is of course a somewhat ugly hack, whereas the former would be a proper fix. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160314/ba929e88/attachment-0001.sig> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y @ 2016-03-14 12:18 ` Thierry Reding 0 siblings, 0 replies; 8+ messages in thread From: Thierry Reding @ 2016-03-14 12:18 UTC (permalink / raw) To: Andy Yan Cc: arnd, javier, kgene, k.kozlowski, geert+renesas, linux-kernel, public_timo.s, linux, alexandre.belloni, sjoerd.simons, olof, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 836 bytes --] On Sat, Mar 12, 2016 at 08:50:29PM +0800, Andy Yan wrote: > All the current rk3066 based boards use pwm modulate vdd_logic > voltage, the board may hang when the system boot and run to a higher > frequency without pwm enabled, so enable it as builtin. I don't understand the rationale here. Surely if the system can't safely switch to a higher frequency because the regulator isn't available, then it should be prevented from switching, shouldn't it? Making this change alone will not prevent users from switching this back to =m on their own. So either you need to add code to prevent a switch to an unsupported frequency in the absence of the regulator, or you need to change the PWM_ROCKCHIP Kconfig option to be bool instead, though the latter is of course a somewhat ugly hack, whereas the former would be a proper fix. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-03-14 12:21 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-03-12 12:50 [PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y Andy Yan 2016-03-12 12:50 ` Andy Yan 2016-03-12 12:51 ` [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y Andy Yan 2016-03-12 12:51 ` Andy Yan 2016-03-14 12:21 ` Thierry Reding 2016-03-14 12:21 ` Thierry Reding 2016-03-14 12:18 ` [PATCH 1/2] ARM: multi_v7_defconfig: enable CONFIG_PWM_ROCKCHIP=y Thierry Reding 2016-03-14 12:18 ` Thierry Reding
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.