From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
jlayton@poochiereds.net, bfields@fieldses.org,
Vlastimil Babka <vbabka@suse.cz>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
koct9i@gmail.com, aquini@redhat.com,
virtualization@lists.linux-foundation.org,
Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
rknize@motorola.com, Rik van Riel <riel@redhat.com>,
Gioh Kim <gurugio@hanmail.net>
Subject: Re: [PATCH v1 06/19] zsmalloc: clean up many BUG_ON
Date: Tue, 15 Mar 2016 15:19:46 +0900 [thread overview]
Message-ID: <20160315061946.GB1464@swordfish> (raw)
In-Reply-To: <1457681423-26664-7-git-send-email-minchan@kernel.org>
On (03/11/16 16:30), Minchan Kim wrote:
> There are many BUG_ON in zsmalloc.c which is not recommened so
> change them as alternatives.
>
> Normal rule is as follows:
>
> 1. avoid BUG_ON if possible. Instead, use VM_BUG_ON or VM_BUG_ON_PAGE
> 2. use VM_BUG_ON_PAGE if we need to see struct page's fields
> 3. use those assertion in primitive functions so higher functions
> can rely on the assertion in the primitive function.
> 4. Don't use assertion if following instruction can trigger Oops
>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
jlayton@poochiereds.net, bfields@fieldses.org,
Vlastimil Babka <vbabka@suse.cz>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
koct9i@gmail.com, aquini@redhat.com,
virtualization@lists.linux-foundation.org,
Mel Gorman <mgorman@suse.de>, Hugh Dickins <hughd@google.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
rknize@motorola.com, Rik van Riel <riel@redhat.com>,
Gioh Kim <gurugio@hanmail.net>
Subject: Re: [PATCH v1 06/19] zsmalloc: clean up many BUG_ON
Date: Tue, 15 Mar 2016 15:19:46 +0900 [thread overview]
Message-ID: <20160315061946.GB1464@swordfish> (raw)
In-Reply-To: <1457681423-26664-7-git-send-email-minchan@kernel.org>
On (03/11/16 16:30), Minchan Kim wrote:
> There are many BUG_ON in zsmalloc.c which is not recommened so
> change them as alternatives.
>
> Normal rule is as follows:
>
> 1. avoid BUG_ON if possible. Instead, use VM_BUG_ON or VM_BUG_ON_PAGE
> 2. use VM_BUG_ON_PAGE if we need to see struct page's fields
> 3. use those assertion in primitive functions so higher functions
> can rely on the assertion in the primitive function.
> 4. Don't use assertion if following instruction can trigger Oops
>
> Signed-off-by: Minchan Kim <minchan@kernel.org>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
next prev parent reply other threads:[~2016-03-15 6:18 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 7:30 [PATCH v1 00/19] Support non-lru page migration Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 01/19] mm: use put_page to free page instead of putback_lru_page Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-14 8:48 ` Vlastimil Babka
2016-03-14 8:48 ` Vlastimil Babka
2016-03-14 8:48 ` Vlastimil Babka
2016-03-15 1:16 ` Minchan Kim
2016-03-15 1:16 ` Minchan Kim
2016-03-15 1:16 ` Minchan Kim
2016-03-15 19:06 ` Vlastimil Babka
2016-03-15 19:06 ` Vlastimil Babka
2016-03-15 19:06 ` Vlastimil Babka
2016-03-11 7:30 ` [PATCH v1 02/19] mm/compaction: support non-lru movable page migration Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 8:11 ` kbuild test robot
2016-03-11 8:11 ` kbuild test robot
2016-03-11 8:11 ` kbuild test robot
2016-03-11 8:11 ` kbuild test robot
2016-03-11 8:35 ` Minchan Kim
2016-03-11 8:35 ` Minchan Kim
2016-03-11 8:35 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 03/19] fs/anon_inodes: new interface to create new inode Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 8:05 ` Al Viro
2016-03-11 8:05 ` Al Viro
2016-03-11 14:24 ` Gioh Kim
2016-03-11 14:24 ` Gioh Kim
2016-03-11 14:24 ` Gioh Kim
2016-03-11 8:05 ` Al Viro
2016-03-11 7:30 ` [PATCH v1 04/19] mm/balloon: use general movable page feature into balloon Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 05/19] zsmalloc: use first_page rather than page Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-15 6:19 ` Sergey Senozhatsky
2016-03-15 6:19 ` Sergey Senozhatsky
2016-03-15 6:19 ` Sergey Senozhatsky
2016-03-11 7:30 ` [PATCH v1 06/19] zsmalloc: clean up many BUG_ON Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-15 6:19 ` Sergey Senozhatsky [this message]
2016-03-15 6:19 ` Sergey Senozhatsky
2016-03-15 6:19 ` Sergey Senozhatsky
2016-03-11 7:30 ` [PATCH v1 07/19] zsmalloc: reordering function parameter Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-15 6:20 ` Sergey Senozhatsky
2016-03-15 6:20 ` Sergey Senozhatsky
2016-03-15 6:20 ` Sergey Senozhatsky
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 08/19] zsmalloc: remove unused pool param in obj_free Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-15 6:21 ` Sergey Senozhatsky
2016-03-15 6:21 ` Sergey Senozhatsky
2016-03-15 6:21 ` Sergey Senozhatsky
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 09/19] zsmalloc: keep max_object in size_class Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-12 1:44 ` xuyiping
2016-03-12 1:44 ` xuyiping
2016-03-12 1:44 ` xuyiping
2016-03-14 4:55 ` Minchan Kim
2016-03-14 4:55 ` Minchan Kim
2016-03-14 4:55 ` Minchan Kim
2016-03-15 6:28 ` Sergey Senozhatsky
2016-03-15 6:28 ` Sergey Senozhatsky
2016-03-15 6:41 ` Minchan Kim
2016-03-15 6:41 ` Minchan Kim
2016-03-15 6:41 ` Minchan Kim
2016-03-15 6:28 ` Sergey Senozhatsky
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 10/19] zsmalloc: squeeze inuse into page->mapping Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 11/19] zsmalloc: squeeze freelist " Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-15 6:40 ` Sergey Senozhatsky
2016-03-15 6:40 ` Sergey Senozhatsky
2016-03-15 6:51 ` Minchan Kim
2016-03-15 6:51 ` Minchan Kim
2016-03-17 12:09 ` YiPing Xu
2016-03-17 12:09 ` YiPing Xu
2016-03-17 22:17 ` Minchan Kim
2016-03-17 22:17 ` Minchan Kim
2016-03-17 22:17 ` Minchan Kim
2016-03-17 12:09 ` YiPing Xu
2016-03-15 6:51 ` Minchan Kim
2016-03-15 6:40 ` Sergey Senozhatsky
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 12/19] zsmalloc: move struct zs_meta from mapping to freelist Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 13/19] zsmalloc: factor page chain functionality out Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-12 3:09 ` xuyiping
2016-03-12 3:09 ` xuyiping
2016-03-12 3:09 ` xuyiping
2016-03-14 4:58 ` Minchan Kim
2016-03-14 4:58 ` Minchan Kim
2016-03-14 4:58 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 14/19] zsmalloc: separate free_zspage from putback_zspage Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 15/19] zsmalloc: zs_compact refactoring Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 16/19] zsmalloc: migrate head page of zspage Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 17/19] zsmalloc: use single linked list for page chain Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 18/19] zsmalloc: migrate tail pages in zspage Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-11 7:30 ` [PATCH v1 19/19] zram: use __GFP_MOVABLE for memory allocation Minchan Kim
2016-03-11 7:30 ` Minchan Kim
2016-03-15 6:56 ` Sergey Senozhatsky
2016-03-15 6:56 ` Sergey Senozhatsky
2016-03-15 6:56 ` Sergey Senozhatsky
2016-03-11 7:30 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315061946.GB1464@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=bfields@fieldses.org \
--cc=gurugio@hanmail.net \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jlayton@poochiereds.net \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=rknize@motorola.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.