* [patch] PCI: xilinx-nwl: fix an error code in nwl_pcie_init_irq_domain()
@ 2016-03-15 7:12 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2016-03-15 7:12 UTC (permalink / raw)
To: Bjorn Helgaas, Bharat Kumar Gogada
Cc: Michal Simek, Sören Brinkmann, Marc Zyngier, Rob Herring,
Ravi Kiran Gummaluri, linux-pci, linux-kernel, kernel-janitors
Returning PTR_ERR(legacy_intc_node) is zero which is success but we want
to return a negative error code.
Fixes: 4337ea1d4b10 ('PCI: xilinx-nwl: Add support for Xilinx NWL PCIe Host Controller')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/pci/host/pcie-xilinx-nwl.c b/drivers/pci/host/pcie-xilinx-nwl.c
index 7a2dc2e..5139e64 100644
--- a/drivers/pci/host/pcie-xilinx-nwl.c
+++ b/drivers/pci/host/pcie-xilinx-nwl.c
@@ -525,7 +525,7 @@ static int nwl_pcie_init_irq_domain(struct nwl_pcie *pcie)
legacy_intc_node = of_get_next_child(node, NULL);
if (!legacy_intc_node) {
dev_err(pcie->dev, "No legacy intc node found\n");
- return PTR_ERR(legacy_intc_node);
+ return -EINVAL;
}
pcie->legacy_irq_domain = irq_domain_add_linear(legacy_intc_node,
^ permalink raw reply related [flat|nested] 2+ messages in thread* [patch] PCI: xilinx-nwl: fix an error code in nwl_pcie_init_irq_domain()
@ 2016-03-15 7:12 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2016-03-15 7:12 UTC (permalink / raw)
To: Bjorn Helgaas, Bharat Kumar Gogada
Cc: Michal Simek, Sören Brinkmann, Marc Zyngier, Rob Herring,
Ravi Kiran Gummaluri, linux-pci, linux-kernel, kernel-janitors
Returning PTR_ERR(legacy_intc_node) is zero which is success but we want
to return a negative error code.
Fixes: 4337ea1d4b10 ('PCI: xilinx-nwl: Add support for Xilinx NWL PCIe Host Controller')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/pci/host/pcie-xilinx-nwl.c b/drivers/pci/host/pcie-xilinx-nwl.c
index 7a2dc2e..5139e64 100644
--- a/drivers/pci/host/pcie-xilinx-nwl.c
+++ b/drivers/pci/host/pcie-xilinx-nwl.c
@@ -525,7 +525,7 @@ static int nwl_pcie_init_irq_domain(struct nwl_pcie *pcie)
legacy_intc_node = of_get_next_child(node, NULL);
if (!legacy_intc_node) {
dev_err(pcie->dev, "No legacy intc node found\n");
- return PTR_ERR(legacy_intc_node);
+ return -EINVAL;
}
pcie->legacy_irq_domain = irq_domain_add_linear(legacy_intc_node,
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-15 7:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-15 7:12 [patch] PCI: xilinx-nwl: fix an error code in nwl_pcie_init_irq_domain() Dan Carpenter
2016-03-15 7:12 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.