From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: santosh shilimkar <santosh.shilimkar@oracle.com>,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket
Date: Tue, 15 Mar 2016 13:30:11 -0400 [thread overview]
Message-ID: <20160315173011.GM11063@oracle.com> (raw)
In-Reply-To: <1458062294.31401.37.camel@edumazet-glaptop3.roam.corp.google.com>
On (03/15/16 10:18), Eric Dumazet wrote:
>
> Look at SO_SNDBUF and SO_RCVBUF implementation.
>
> sk->sk_sndbuf = max_t(u32, val * 2, SOCK_MIN_SNDBUF);
>
> sk->sk_rcvbuf = max_t(u32, val * 2, SOCK_MIN_RCVBUF);
>
> kernel definitely has some logic here.
Ok, I can do the same thing (and we do this consistently across
all drivers?)
> If you believe SOCK_MIN_SNDBUF and/or SOCK_MIN_RCVBUF are wrong, please
> elaborate.
I dont recall suggesting that.
BTW, when I tried it, doing a SO_SNDBUF of 1 from uspace does not return
an error. It merely sets the buffer size to 4608 (as reported by
getsockopt in my env. I think the getsockopt value is impacted by
many factors).
--Sowmini
next prev parent reply other threads:[~2016-03-15 17:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 15:12 [PATCH v2 net-next] rds-tcp: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket Sowmini Varadhan
2016-03-15 16:38 ` santosh shilimkar
2016-03-15 16:58 ` Sowmini Varadhan
2016-03-15 17:18 ` Eric Dumazet
2016-03-15 17:30 ` Sowmini Varadhan [this message]
2016-03-15 18:09 ` Eric Dumazet
2016-03-15 18:16 ` Sowmini Varadhan
2016-03-15 17:30 ` Tom Herbert
2016-03-15 17:34 ` Sowmini Varadhan
2016-03-15 17:47 ` Tom Herbert
2016-03-15 19:57 ` Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315173011.GM11063@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.