From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Christopher Heiny <cheiny@synaptics.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND
Date: Tue, 15 Mar 2016 23:45:36 +0000 [thread overview]
Message-ID: <20160315234536.GA29178@dtor-ws> (raw)
In-Reply-To: <56E87C82.7080105@synaptics.com>
On Tue, Mar 15, 2016 at 02:20:02PM -0700, Andrew Duggan wrote:
> On 03/15/2016 12:11 AM, Dan Carpenter wrote:
> >There is a typo so we have && instead of &.
> >
> >Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Andrew Duggan <aduggan@synaptics.com>
Applied, thank you.
>
> >diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
> >index 77a5eb8..ec8a10d 100644
> >--- a/drivers/input/rmi4/rmi_f11.c
> >+++ b/drivers/input/rmi4/rmi_f11.c
> >@@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
> > sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS);
> > sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES);
> > sensor_query->has_sensitivity_adjust > >- !!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ);
> >+ !!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ);
> > sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE);
> > sensor_query->nr_x_electrodes > >@@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
> > sensor_query->has_bending_correction > > !!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION);
> > sensor_query->has_large_object_suppression > >- !!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
> >+ !!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
> > sensor_query->has_jitter_filter > > !!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER);
> > query_size++;
>
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Christopher Heiny <cheiny@synaptics.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND
Date: Tue, 15 Mar 2016 16:45:36 -0700 [thread overview]
Message-ID: <20160315234536.GA29178@dtor-ws> (raw)
In-Reply-To: <56E87C82.7080105@synaptics.com>
On Tue, Mar 15, 2016 at 02:20:02PM -0700, Andrew Duggan wrote:
> On 03/15/2016 12:11 AM, Dan Carpenter wrote:
> >There is a typo so we have && instead of &.
> >
> >Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Andrew Duggan <aduggan@synaptics.com>
Applied, thank you.
>
> >diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
> >index 77a5eb8..ec8a10d 100644
> >--- a/drivers/input/rmi4/rmi_f11.c
> >+++ b/drivers/input/rmi4/rmi_f11.c
> >@@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
> > sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS);
> > sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES);
> > sensor_query->has_sensitivity_adjust =
> >- !!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ);
> >+ !!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ);
> > sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE);
> > sensor_query->nr_x_electrodes =
> >@@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
> > sensor_query->has_bending_correction =
> > !!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION);
> > sensor_query->has_large_object_suppression =
> >- !!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
> >+ !!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
> > sensor_query->has_jitter_filter =
> > !!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER);
> > query_size++;
>
--
Dmitry
next prev parent reply other threads:[~2016-03-15 23:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 7:11 [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND Dan Carpenter
2016-03-15 7:11 ` Dan Carpenter
2016-03-15 8:33 ` Joe Perches
2016-03-15 8:33 ` Joe Perches
2016-03-15 8:33 ` Joe Perches
2016-03-15 8:37 ` Dan Carpenter
2016-03-15 8:37 ` Dan Carpenter
2016-03-15 8:54 ` Joe Perches
2016-03-15 8:54 ` Joe Perches
2016-03-15 21:20 ` Andrew Duggan
2016-03-15 21:20 ` Andrew Duggan
2016-03-15 21:20 ` Andrew Duggan
2016-03-15 23:45 ` Dmitry Torokhov [this message]
2016-03-15 23:45 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315234536.GA29178@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aduggan@synaptics.com \
--cc=cheiny@synaptics.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.