From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/2] power: reset: at91-shdwc: add new shutdown controller driver
Date: Wed, 16 Mar 2016 13:07:49 +0100 [thread overview]
Message-ID: <20160316120749.GC20227@piout.net> (raw)
In-Reply-To: <56E94558.9010506@atmel.com>
On 16/03/2016 at 12:36:56 +0100, Nicolas Ferre wrote :
> I don't agree with you on the 2 last ones. In Documentation/CodingStyle,
> it is said that:
>
> "Chapter 2: Breaking long lines and strings
> [..]
> Descendants are always substantially shorter than the parent and
> are placed substantially to the right."
>
> Together with the 80 column requirement that I also fulfil, I think that
> my code is well aligned.
>
> So I keep it like this ;-)
>
checkpatch.pl --strict disagrees with you
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org
Subject: Re: [PATCH v4 2/2] power: reset: at91-shdwc: add new shutdown controller driver
Date: Wed, 16 Mar 2016 13:07:49 +0100 [thread overview]
Message-ID: <20160316120749.GC20227@piout.net> (raw)
In-Reply-To: <56E94558.9010506-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
On 16/03/2016 at 12:36:56 +0100, Nicolas Ferre wrote :
> I don't agree with you on the 2 last ones. In Documentation/CodingStyle,
> it is said that:
>
> "Chapter 2: Breaking long lines and strings
> [..]
> Descendants are always substantially shorter than the parent and
> are placed substantially to the right."
>
> Together with the 80 column requirement that I also fulfil, I think that
> my code is well aligned.
>
> So I keep it like this ;-)
>
checkpatch.pl --strict disagrees with you
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org, sre@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk
Subject: Re: [PATCH v4 2/2] power: reset: at91-shdwc: add new shutdown controller driver
Date: Wed, 16 Mar 2016 13:07:49 +0100 [thread overview]
Message-ID: <20160316120749.GC20227@piout.net> (raw)
In-Reply-To: <56E94558.9010506@atmel.com>
On 16/03/2016 at 12:36:56 +0100, Nicolas Ferre wrote :
> I don't agree with you on the 2 last ones. In Documentation/CodingStyle,
> it is said that:
>
> "Chapter 2: Breaking long lines and strings
> [..]
> Descendants are always substantially shorter than the parent and
> are placed substantially to the right."
>
> Together with the 80 column requirement that I also fulfil, I think that
> my code is well aligned.
>
> So I keep it like this ;-)
>
checkpatch.pl --strict disagrees with you
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-16 12:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 15:37 [PATCH v4 0/2] power: reset: support for Atmel alternative Shutdown Controller Nicolas Ferre
2016-03-10 15:37 ` Nicolas Ferre
2016-03-10 15:37 ` Nicolas Ferre
2016-03-10 15:37 ` [PATCH v4 1/2] ARM: dts: at91: shdwc binding: add new shutdown controller documentation Nicolas Ferre
2016-03-10 15:37 ` Nicolas Ferre
2016-03-10 15:37 ` Nicolas Ferre
2016-03-10 15:37 ` [PATCH v4 2/2] power: reset: at91-shdwc: add new shutdown controller driver Nicolas Ferre
2016-03-10 15:37 ` Nicolas Ferre
2016-03-10 15:37 ` Nicolas Ferre
2016-03-14 20:22 ` Alexandre Belloni
2016-03-14 20:22 ` Alexandre Belloni
2016-03-14 20:22 ` Alexandre Belloni
2016-03-16 11:36 ` Nicolas Ferre
2016-03-16 11:36 ` Nicolas Ferre
2016-03-16 11:36 ` Nicolas Ferre
2016-03-16 12:07 ` Alexandre Belloni [this message]
2016-03-16 12:07 ` Alexandre Belloni
2016-03-16 12:07 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316120749.GC20227@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.