Re: [PATCH v3] ASoC: Intel: Skylake: remove call to pci_dev_put

Re: [PATCH v3] ASoC: Intel: Skylake: remove call to pci_dev_put

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 392 bytes --]

On Wed, Mar 16, 2016 at 09:37:18PM +0530, Vinod Koul wrote:
> The PCI bus takes pci_dev_get() and pci_dev_put() is also there.
> So no need for drivers to invoke these. In SKL driver we were
> calling pci_dev_put() only which is not right, so remove this

This doesn't seem to apply against current code (I don't have the
relevant SHA1s for the dependency) - can you please check and resend?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

[PATCH v3] ASoC: Intel: Skylake: remove call to pci_dev_put

[Vinod Koul]

The PCI bus takes pci_dev_get() and pci_dev_put() is also there.
So no need for drivers to invoke these. In SKL driver we were
calling pci_dev_put() only which is not right, so remove this

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/skylake/skl.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
index b67f3bd0fccd..c337d06793ec 100644
--- a/sound/soc/intel/skylake/skl.c
+++ b/sound/soc/intel/skylake/skl.c
@@ -732,7 +732,6 @@ static void skl_remove(struct pci_dev *pci)
 
 	if (pci_dev_run_wake(pci))
 		pm_runtime_get_noresume(&pci->dev);
-	pci_dev_put(pci);
 	skl_codecs_remove(ebus);
 	skl_platform_unregister(&pci->dev);
 	skl_free_dsp(skl);
-- 
1.9.1

Re: [PATCH v3] ASoC: Intel: Skylake: remove call to pci_dev_put

[Vinod Koul]

[-- Attachment #1.1: Type: text/plain, Size: 621 bytes --]

On Wed, Mar 16, 2016 at 04:07:17PM +0000, Mark Brown wrote:
> On Wed, Mar 16, 2016 at 09:37:18PM +0530, Vinod Koul wrote:
> > The PCI bus takes pci_dev_get() and pci_dev_put() is also there.
> > So no need for drivers to invoke these. In SKL driver we were
> > calling pci_dev_put() only which is not right, so remove this
> 
> This doesn't seem to apply against current code (I don't have the
> relevant SHA1s for the dependency) - can you please check and resend?

Thats surprising as I amended the commit in last series and sent this one. I
will re-fetch your tree and do this again.

Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH v3] ASoC: Intel: Skylake: remove call to pci_dev_put

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 448 bytes --]

On Wed, Mar 16, 2016 at 09:46:05PM +0530, Vinod Koul wrote:
> On Wed, Mar 16, 2016 at 04:07:17PM +0000, Mark Brown wrote:

> > This doesn't seem to apply against current code (I don't have the
> > relevant SHA1s for the dependency) - can you please check and resend?

> Thats surprising as I amended the commit in last series and sent this one. I
> will re-fetch your tree and do this again.

Is it depending on some -next only stuff or something?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]