From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Kees Cook <keescook@chromium.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
kernel-hardening@lists.openwall.com,
Ingo Molnar <mingo@kernel.org>
Subject: [kernel-hardening] Re: [PATCH] s390: disable postinit-readonly for now
Date: Thu, 17 Mar 2016 09:49:11 +0100 [thread overview]
Message-ID: <20160317084911.GA3995@osiris> (raw)
In-Reply-To: <56E9B860.2060802@de.ibm.com>
On Wed, Mar 16, 2016 at 08:47:44PM +0100, Christian Borntraeger wrote:
> On 03/10/2016 06:31 PM, Kees Cook wrote:
> > This is a temporary fix to let lkdtm run again on s390, though it'll
> > still fail the ro_after_init tests. Until rodata and ro_after_init
> > sections can be split on s390, disable special handling of ro_after_init.
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> > ---
> > for -next ...
>
> Given that the other patches are already merged in linus master via Ingo,
> do you want this to go via Ingo as well?
Let's route this via the s390 tree. I will add another patch to get rid of
the bogus "This architecture does not have kernel memory protection."
message printed to the console, just like parisc.
> > ---
> > arch/s390/include/asm/cache.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/s390/include/asm/cache.h b/arch/s390/include/asm/cache.h
> > index 4d7ccac5fd1d..22da3b34c655 100644
> > --- a/arch/s390/include/asm/cache.h
> > +++ b/arch/s390/include/asm/cache.h
> > @@ -15,4 +15,7 @@
> >
> > #define __read_mostly __attribute__((__section__(".data..read_mostly")))
> >
> > +/* Read-only memory is marked before mark_rodata_ro() is called. */
> > +#define __ro_after_init __read_mostly
> > +
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Kees Cook <keescook@chromium.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
kernel-hardening@lists.openwall.com,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] s390: disable postinit-readonly for now
Date: Thu, 17 Mar 2016 09:49:11 +0100 [thread overview]
Message-ID: <20160317084911.GA3995@osiris> (raw)
In-Reply-To: <56E9B860.2060802@de.ibm.com>
On Wed, Mar 16, 2016 at 08:47:44PM +0100, Christian Borntraeger wrote:
> On 03/10/2016 06:31 PM, Kees Cook wrote:
> > This is a temporary fix to let lkdtm run again on s390, though it'll
> > still fail the ro_after_init tests. Until rodata and ro_after_init
> > sections can be split on s390, disable special handling of ro_after_init.
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> > ---
> > for -next ...
>
> Given that the other patches are already merged in linus master via Ingo,
> do you want this to go via Ingo as well?
Let's route this via the s390 tree. I will add another patch to get rid of
the bogus "This architecture does not have kernel memory protection."
message printed to the console, just like parisc.
> > ---
> > arch/s390/include/asm/cache.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/s390/include/asm/cache.h b/arch/s390/include/asm/cache.h
> > index 4d7ccac5fd1d..22da3b34c655 100644
> > --- a/arch/s390/include/asm/cache.h
> > +++ b/arch/s390/include/asm/cache.h
> > @@ -15,4 +15,7 @@
> >
> > #define __read_mostly __attribute__((__section__(".data..read_mostly")))
> >
> > +/* Read-only memory is marked before mark_rodata_ro() is called. */
> > +#define __ro_after_init __read_mostly
> > +
next prev parent reply other threads:[~2016-03-17 8:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 17:31 [kernel-hardening] [PATCH] s390: disable postinit-readonly for now Kees Cook
2016-03-10 17:31 ` Kees Cook
2016-03-12 11:15 ` [kernel-hardening] " Heiko Carstens
2016-03-12 11:15 ` Heiko Carstens
2016-03-16 19:47 ` [kernel-hardening] " Christian Borntraeger
2016-03-16 19:47 ` Christian Borntraeger
2016-03-17 8:49 ` Heiko Carstens [this message]
2016-03-17 8:49 ` Heiko Carstens
2016-03-21 19:33 ` [kernel-hardening] " Kees Cook
2016-03-21 19:33 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317084911.GA3995@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.