From: Lee Jones <lee.jones@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, heiko@sntech.de,
patches@linaro.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] ARM: Rockchip: Fix use of plain integer as NULL pointer
Date: Thu, 17 Mar 2016 13:29:43 +0000 [thread overview]
Message-ID: <20160317132943.GC13692@x1> (raw)
In-Reply-To: <1458213099-13786-1-git-send-email-peter.griffin@linaro.org>
Nit: Subject line doesn't match the preferred format for the sub-arch.
On Thu, 17 Mar 2016, Peter Griffin wrote:
> This fixes the following sparse build warning
> mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer
Nit: I would insert a '\n' between your wording and the quoted
warning. For added clarity, I usually stick a tab before the quote.
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> arch/arm/mach-rockchip/platsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch looks good though:
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
> index d42a07e..4d827a0 100644
> --- a/arch/arm/mach-rockchip/platsmp.c
> +++ b/arch/arm/mach-rockchip/platsmp.c
> @@ -65,7 +65,7 @@ static struct reset_control *rockchip_get_core_reset(int cpu)
> if (dev)
> np = dev->of_node;
> else
> - np = of_get_cpu_node(cpu, 0);
> + np = of_get_cpu_node(cpu, NULL);
>
> return of_reset_control_get(np, NULL);
> }
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Rockchip: Fix use of plain integer as NULL pointer
Date: Thu, 17 Mar 2016 13:29:43 +0000 [thread overview]
Message-ID: <20160317132943.GC13692@x1> (raw)
In-Reply-To: <1458213099-13786-1-git-send-email-peter.griffin@linaro.org>
Nit: Subject line doesn't match the preferred format for the sub-arch.
On Thu, 17 Mar 2016, Peter Griffin wrote:
> This fixes the following sparse build warning
> mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer
Nit: I would insert a '\n' between your wording and the quoted
warning. For added clarity, I usually stick a tab before the quote.
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> arch/arm/mach-rockchip/platsmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch looks good though:
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
> index d42a07e..4d827a0 100644
> --- a/arch/arm/mach-rockchip/platsmp.c
> +++ b/arch/arm/mach-rockchip/platsmp.c
> @@ -65,7 +65,7 @@ static struct reset_control *rockchip_get_core_reset(int cpu)
> if (dev)
> np = dev->of_node;
> else
> - np = of_get_cpu_node(cpu, 0);
> + np = of_get_cpu_node(cpu, NULL);
>
> return of_reset_control_get(np, NULL);
> }
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-03-17 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 11:11 [PATCH] ARM: Rockchip: Fix use of plain integer as NULL pointer Peter Griffin
2016-03-17 11:11 ` Peter Griffin
2016-03-17 13:29 ` Lee Jones [this message]
2016-03-17 13:29 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317132943.GC13692@x1 \
--to=lee.jones@linaro.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=patches@linaro.org \
--cc=peter.griffin@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.