All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: pali.rohar@gmail.com, sre@kernel.org,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
	aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
	patrikbachan@gmail.com, serge@hallyn.com,
	maxime.ripard@free-electrons.com, ruslan.bilovol@gmail.com,
	m.szyprowski@samsung.com, peter.chen@freescale.com, balbi@ti.com
Subject: usb: gadget breakage on N900: bind UDC by name passed via usb_gadget_driver structure
Date: Thu, 17 Mar 2016 22:26:03 +0100	[thread overview]
Message-ID: <20160317212603.GA16651@amd> (raw)

Hi!

USB gadget stops working for me on n900, if I merge

usb: gadget: bind UDC by name passed via usb_gadget_driver structure

patch.

commit 2284b29d3d9dd16490909962574d7f3fef83fd97
Author: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Date:   Mon Nov 23 09:56:35 2015 +0100

    usb: gadget: bind UDC by name passed via usb_gadget_driver
    structure

    Introduce new 'udc_name' member to usb_gadget_driver structure.
        The 'udc_name' is a name of UDC that usb_gadget_driver should
	    be bound to. If udc_name is NULL, it will be bound to any
	        available UDC.

    Tested-by: Maxime Ripard <maxime.ripard@free-electrons.com>
        Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
	    Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
	        Tested-by: Peter Chen <peter.chen@freescale.com>
		    Signed-off-by: Felipe Balbi <balbi@ti.com>


Patch is obvious enough... if there's someone who sets udc_name to
NULL. Who is supposed to do that?

(I have patch in my tree to make USB gadget work when it is not
modular).

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: usb: gadget breakage on N900: bind UDC by name passed via usb_gadget_driver structure
Date: Thu, 17 Mar 2016 22:26:03 +0100	[thread overview]
Message-ID: <20160317212603.GA16651@amd> (raw)

Hi!

USB gadget stops working for me on n900, if I merge

usb: gadget: bind UDC by name passed via usb_gadget_driver structure

patch.

commit 2284b29d3d9dd16490909962574d7f3fef83fd97
Author: Ruslan Bilovol <ruslan.bilovol@gmail.com>
Date:   Mon Nov 23 09:56:35 2015 +0100

    usb: gadget: bind UDC by name passed via usb_gadget_driver
    structure

    Introduce new 'udc_name' member to usb_gadget_driver structure.
        The 'udc_name' is a name of UDC that usb_gadget_driver should
	    be bound to. If udc_name is NULL, it will be bound to any
	        available UDC.

    Tested-by: Maxime Ripard <maxime.ripard@free-electrons.com>
        Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
	    Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
	        Tested-by: Peter Chen <peter.chen@freescale.com>
		    Signed-off-by: Felipe Balbi <balbi@ti.com>


Patch is obvious enough... if there's someone who sets udc_name to
NULL. Who is supposed to do that?

(I have patch in my tree to make USB gadget work when it is not
modular).

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

             reply	other threads:[~2016-03-17 21:26 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 21:26 Pavel Machek [this message]
2016-03-17 21:26 ` usb: gadget breakage on N900: bind UDC by name passed via usb_gadget_driver structure Pavel Machek
2016-03-18  7:47 ` Ruslan Bilovol
2016-03-18  7:47   ` Ruslan Bilovol
2016-03-18  9:32   ` Pavel Machek
2016-03-18  9:32     ` Pavel Machek
2016-03-18 20:20   ` Pavel Machek
2016-03-18 20:20     ` Pavel Machek
2016-03-21 11:51     ` Marek Szyprowski
2016-03-21 11:51       ` Marek Szyprowski
2016-03-23 12:21       ` Pavel Machek
2016-03-23 12:21         ` Pavel Machek
2016-03-24  0:45         ` Ruslan Bilovol
2016-03-24  0:45           ` Ruslan Bilovol
2016-03-25  3:21           ` Ruslan Bilovol
2016-03-25  3:21             ` Ruslan Bilovol
2016-03-25 21:09             ` Pavel Machek
2016-03-25 21:09               ` Pavel Machek
2016-03-26 21:32               ` Ruslan Bilovol
2016-03-26 21:32                 ` Ruslan Bilovol
2016-03-26 21:59                 ` Ruslan Bilovol
2016-03-26 21:59                   ` Ruslan Bilovol
2016-03-27 20:26                 ` Pavel Machek
2016-03-27 20:26                   ` Pavel Machek
2016-03-27 21:44                   ` Ruslan Bilovol
2016-03-27 21:44                     ` Ruslan Bilovol
2016-03-28 21:33                     ` Pavel Machek
2016-03-28 21:33                       ` Pavel Machek
2016-04-01 14:38                     ` Pavel Machek
2016-04-01 14:38                       ` Pavel Machek
2016-03-25 21:15             ` Pavel Machek
2016-03-25 21:15               ` Pavel Machek
2016-03-26 21:41               ` Ruslan Bilovol
2016-03-26 21:41                 ` Ruslan Bilovol
2016-03-25 21:30             ` Pavel Machek
2016-03-25 21:30               ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160317212603.GA16651@amd \
    --to=pavel@ucw.cz \
    --cc=aaro.koskinen@iki.fi \
    --cc=balbi@ti.com \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=pali.rohar@gmail.com \
    --cc=patrikbachan@gmail.com \
    --cc=peter.chen@freescale.com \
    --cc=ruslan.bilovol@gmail.com \
    --cc=serge@hallyn.com \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.