From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral
Date: Sat, 19 Mar 2016 00:08:19 +0100 [thread overview]
Message-ID: <20160318230819.GF2828@piout.net> (raw)
In-Reply-To: <1458005918-7893-1-git-send-email-javier@osg.samsung.com>
On 14/03/2016 at 22:38:38 -0300, Javier Martinez Canillas wrote :
> The clock and source clock looked up by the driver may not be available
> just because the clock controller driver was not probed yet so printing
> an error in this case is not correct and only adds confusion to users.
>
> However, knowing that a driver's probe was deferred may be useful so it
> can be printed as a debug information.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes in v3:
> - Change debug messages again as suggested by Joe Perches.
>
> Changes in v2:
> - Improve debug messages as suggested by Joe Perches.
>
> drivers/rtc/rtc-s3c.c | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
rtc-linux@googlegroups.com
Subject: Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral
Date: Sat, 19 Mar 2016 00:08:19 +0100 [thread overview]
Message-ID: <20160318230819.GF2828@piout.net> (raw)
In-Reply-To: <1458005918-7893-1-git-send-email-javier@osg.samsung.com>
On 14/03/2016 at 22:38:38 -0300, Javier Martinez Canillas wrote :
> The clock and source clock looked up by the driver may not be available
> just because the clock controller driver was not probed yet so printing
> an error in this case is not correct and only adds confusion to users.
>
> However, knowing that a driver's probe was deferred may be useful so it
> can be printed as a debug information.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes in v3:
> - Change debug messages again as suggested by Joe Perches.
>
> Changes in v2:
> - Improve debug messages as suggested by Joe Perches.
>
> drivers/rtc/rtc-s3c.c | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-18 23:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 1:38 [rtc-linux] [PATCH v3] rtc: s3c: Don't print an error on probe deferral Javier Martinez Canillas
2016-03-15 1:38 ` Javier Martinez Canillas
2016-03-15 1:50 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-15 1:50 ` Krzysztof Kozlowski
2016-03-15 1:59 ` [rtc-linux] " Javier Martinez Canillas
2016-03-15 1:59 ` Javier Martinez Canillas
2016-03-15 2:26 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-15 2:26 ` Krzysztof Kozlowski
2016-03-15 2:58 ` [rtc-linux] " Javier Martinez Canillas
2016-03-15 2:58 ` Javier Martinez Canillas
2016-03-18 11:57 ` [rtc-linux] " Javier Martinez Canillas
2016-03-18 11:57 ` Javier Martinez Canillas
2016-03-18 12:07 ` [rtc-linux] " Alexandre Belloni
2016-03-18 12:07 ` Alexandre Belloni
2016-03-18 12:20 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-18 12:20 ` Krzysztof Kozlowski
2016-03-18 13:56 ` Javier Martinez Canillas
2016-03-18 13:56 ` Javier Martinez Canillas
2016-03-18 13:03 ` Alexandre Belloni
2016-03-18 13:03 ` Alexandre Belloni
2016-03-18 13:44 ` [rtc-linux] " Javier Martinez Canillas
2016-03-18 13:44 ` Javier Martinez Canillas
2016-03-18 23:08 ` Alexandre Belloni [this message]
2016-03-18 23:08 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318230819.GF2828@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=javier@osg.samsung.com \
--cc=joe@perches.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.