From: Jan Viktorin <viktorin@rehivetech.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com,
tomaszx.kulasek@intel.com, jianbo.liu@linaro.org
Subject: Re: [PATCH v3 4/4] eal/arm: introduce CONFIG_RTE_ARCH_ARM_NEON_MEMCPY
Date: Sun, 20 Mar 2016 10:46:55 +0100 [thread overview]
Message-ID: <20160320104655.45a5c863@jvn> (raw)
In-Reply-To: <20160320104110.3c05f405@jvn>
On Sun, 20 Mar 2016 10:41:10 +0100
Jan Viktorin <viktorin@rehivetech.com> wrote:
> On Sat, 19 Mar 2016 21:14:57 +0100
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>
> > 2016-03-19 20:58, Jan Viktorin:
> > > The flag is used to enable memcpy optimizations in EAL. As it is not always
> > > the performance benefit, the flag allows to disable it.
> >
> > Ideally the default should be to choose the best optimization.
> > If it is not possible, it would help to have some comments explaining
> > how to choose wether enabling NEON memcpy or not.
The related statistics are mentioned here:
commit 04a2fde35daf5e9a271e72331a70b48b951d7568
Author: Vlastimil Kosar <kosar@rehivetech.com>
Date: Tue Nov 3 00:47:20 2015 +0100
eal/arm: add vector memcpy for ARMv7
It's quite difficult to easily summarize it, especially for so many
CPUs...
>
> Ok, we can rename the option to CONFIG_RTE_ARCH_ARM_AVOID_NEON_MEMCPY,
> delete it from the defconfig and change the test in rte_memcpy_32.h to
>
> #ifndef CONFIG_RTE_ARCH_ARM_AVOID_NEON_MEMCPY
>
> Alternatively, to have a positive test like
>
> #ifdef CONFIG_RTE_ARCH_ARM_AVOID_NEON_MEMCPY
>
> I can create a bigger change that moves the non-neon-memcpy up in the
> file...
>
> Should I resend the whole series as v3?
>
> Regards
> Jan
--
Jan Viktorin E-mail: Viktorin@RehiveTech.com
System Architect Web: www.RehiveTech.com
RehiveTech
Brno, Czech Republic
next prev parent reply other threads:[~2016-03-20 9:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 9:26 [PATCH v2] arm: detect NEON by RTE_MACHINE_CPUFLAG_NEON flag only Jan Viktorin
2016-03-19 11:05 ` Jan Viktorin
2016-03-19 19:58 ` [PATCH v3 0/4] " Jan Viktorin
2016-03-24 16:47 ` Thomas Monjalon
2016-03-19 19:58 ` [PATCH v3 1/4] arm: remove CONFIG_RTE_ARCH_ARM_NEON Jan Viktorin
2016-03-19 19:58 ` [PATCH v3 2/4] arm: detect NEON cpu feature by checking __ARM_NEON Jan Viktorin
2016-03-20 17:27 ` Jerin Jacob
2016-03-19 19:58 ` [PATCH v3 3/4] arm: detect NEON by checking RTE_MACHINE_CPUFLAG_NEON Jan Viktorin
2016-03-19 19:58 ` [PATCH v3 4/4] eal/arm: introduce CONFIG_RTE_ARCH_ARM_NEON_MEMCPY Jan Viktorin
2016-03-19 20:14 ` Thomas Monjalon
2016-03-20 9:41 ` Jan Viktorin
2016-03-20 9:46 ` Jan Viktorin [this message]
2016-03-20 10:33 ` Thomas Monjalon
2016-03-20 10:29 ` Thomas Monjalon
2016-03-20 17:38 ` Jerin Jacob
2016-03-21 5:42 ` Jianbo Liu
2016-03-21 12:21 ` Jan Viktorin
2016-03-21 13:24 ` Thomas Monjalon
2016-03-21 14:01 ` Jan Viktorin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160320104655.45a5c863@jvn \
--to=viktorin@rehivetech.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@linaro.org \
--cc=thomas.monjalon@6wind.com \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.