From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jan Viktorin <viktorin@rehivetech.com>
Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com,
tomaszx.kulasek@intel.com, jianbo.liu@linaro.org,
david.marchand@6wind.com
Subject: Re: [PATCH v3 0/4] arm: detect NEON by RTE_MACHINE_CPUFLAG_NEON flag only
Date: Thu, 24 Mar 2016 17:47:51 +0100 [thread overview]
Message-ID: <37407375.t09mPlLbzH@xps13> (raw)
In-Reply-To: <1458417485-29436-1-git-send-email-viktorin@rehivetech.com>
2016-03-19 20:58, Jan Viktorin:
> Hello,
>
> finally, I've broken the original patch into 4 pieces as it solves more issues
> and not just a single one.
>
> * As Thomas have already mentioned, the CONFIG_RTE_ARCH_ARM_NEON is confusing.
> So, I've decided to remove it entirely and provide another option for a more
> specific purpose: CONFIG_RTE_ARCH_ARM_NEON_MEMCPY.
>
> * The RTE_MACHINE_CPUFLAG_NEON detection is now based on __ARM_NEON as only
> this compiler definition gives us the arm_neon.h and is compatible with
> arm64. In DPDK, the RTE_MACHINE_CPUFLAG_NEON should be prefered over the
> __ARM_NEON. I'd recommend the same for x86 code (__SSE2__)...
>
> History:
> v2
> * fix l3fwm_em.c to refer RTE_MACHINE_CPUFLAG_NEON instead of __ARM_NEON
>
> v3
> * divided into 4 patches as there are more independent problems
> * compiles well for armv7
> * (probably) fixes RTE_MACHINE_CPUFLAG_NEON detection on arm64
Applied with discussed changes.
next prev parent reply other threads:[~2016-03-24 16:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 9:26 [PATCH v2] arm: detect NEON by RTE_MACHINE_CPUFLAG_NEON flag only Jan Viktorin
2016-03-19 11:05 ` Jan Viktorin
2016-03-19 19:58 ` [PATCH v3 0/4] " Jan Viktorin
2016-03-24 16:47 ` Thomas Monjalon [this message]
2016-03-19 19:58 ` [PATCH v3 1/4] arm: remove CONFIG_RTE_ARCH_ARM_NEON Jan Viktorin
2016-03-19 19:58 ` [PATCH v3 2/4] arm: detect NEON cpu feature by checking __ARM_NEON Jan Viktorin
2016-03-20 17:27 ` Jerin Jacob
2016-03-19 19:58 ` [PATCH v3 3/4] arm: detect NEON by checking RTE_MACHINE_CPUFLAG_NEON Jan Viktorin
2016-03-19 19:58 ` [PATCH v3 4/4] eal/arm: introduce CONFIG_RTE_ARCH_ARM_NEON_MEMCPY Jan Viktorin
2016-03-19 20:14 ` Thomas Monjalon
2016-03-20 9:41 ` Jan Viktorin
2016-03-20 9:46 ` Jan Viktorin
2016-03-20 10:33 ` Thomas Monjalon
2016-03-20 10:29 ` Thomas Monjalon
2016-03-20 17:38 ` Jerin Jacob
2016-03-21 5:42 ` Jianbo Liu
2016-03-21 12:21 ` Jan Viktorin
2016-03-21 13:24 ` Thomas Monjalon
2016-03-21 14:01 ` Jan Viktorin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37407375.t09mPlLbzH@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@linaro.org \
--cc=tomaszx.kulasek@intel.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.