From: Leo Yan <leo.yan@linaro.org>
To: Javi Merino <javi.merino@arm.com>
Cc: Eduardo Valentin <edubezval@gmail.com>,
Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Zhang Rui <rui.zhang@intel.com>,
kongxinwei <kong.kongxinwei@hisilicon.com>,
Punit Agrawal <Punit.Agrawal@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property
Date: Sun, 20 Mar 2016 23:40:31 +0800 [thread overview]
Message-ID: <20160320154031.GA12693@leoy-linaro> (raw)
In-Reply-To: <20160309111051.GA3369@e104805>
Hi Javi,
Sorry for late response.
On Wed, Mar 09, 2016 at 11:10:52AM +0000, Javi Merino wrote:
> On Tue, Mar 08, 2016 at 12:55:59PM -0800, Eduardo Valentin wrote:
> > On Tue, Mar 08, 2016 at 09:57:43PM +0800, Leo Yan wrote:
[...]
> > > > > > > The property "hysteresis" is mandatory for trip points, so if without
> > > > > > > it the thermal zone cannot register successfully. But "hysteresis" is
> > > > > > > ignored in the thermal subsystem and only inquired by several thermal
> > > > > > > sensor drivers.
> > > > > >
> > > > > > If the Linux thermal subsystem has a problem with handling hysteresis, I
> > > > > > would rather fix Linux code than relaxing the DT binding. Or if you
> > > > > > still believe hysteresis is really optional, I would prefer to see a
> > > > > > better justification than "Linux ignores it".
> > > >
> > > > I see it the other way round, Is hysteresis a property that, without
> > > > it, the thermal code can't configure itself so it fails to create the
> > > > trip point? The current code goes "There is no hysteresis for this
> > > > property, I don't know how to set up this trip point!". I think we
> > > > can do better than this.
> > >
> > > Do you agree with Javi's suggestion? If you think it's okay, I will
> > > move on to send out a new version patch based on Javi's comments.
> >
> > No I don't. This discussion so far has been about Linux code. I still
> > havent seen an argument explaining why hysteresis has to be optional.
>
> Fair enough. Looks like I'm holding this driver from being
> upstreamed, so I'll back off.
>
> Leo, sorry for misguiding you. Please bring back the hysteresis
> property you had in v1.
Not at all. I will add back hysteresis property and resend new patches.
Thanks,
Leo Yan
WARNING: multiple messages have this Message-ID (diff)
From: leo.yan@linaro.org (Leo Yan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] thermal: change "hysteresis" as optional property
Date: Sun, 20 Mar 2016 23:40:31 +0800 [thread overview]
Message-ID: <20160320154031.GA12693@leoy-linaro> (raw)
In-Reply-To: <20160309111051.GA3369@e104805>
Hi Javi,
Sorry for late response.
On Wed, Mar 09, 2016 at 11:10:52AM +0000, Javi Merino wrote:
> On Tue, Mar 08, 2016 at 12:55:59PM -0800, Eduardo Valentin wrote:
> > On Tue, Mar 08, 2016 at 09:57:43PM +0800, Leo Yan wrote:
[...]
> > > > > > > The property "hysteresis" is mandatory for trip points, so if without
> > > > > > > it the thermal zone cannot register successfully. But "hysteresis" is
> > > > > > > ignored in the thermal subsystem and only inquired by several thermal
> > > > > > > sensor drivers.
> > > > > >
> > > > > > If the Linux thermal subsystem has a problem with handling hysteresis, I
> > > > > > would rather fix Linux code than relaxing the DT binding. Or if you
> > > > > > still believe hysteresis is really optional, I would prefer to see a
> > > > > > better justification than "Linux ignores it".
> > > >
> > > > I see it the other way round, Is hysteresis a property that, without
> > > > it, the thermal code can't configure itself so it fails to create the
> > > > trip point? The current code goes "There is no hysteresis for this
> > > > property, I don't know how to set up this trip point!". I think we
> > > > can do better than this.
> > >
> > > Do you agree with Javi's suggestion? If you think it's okay, I will
> > > move on to send out a new version patch based on Javi's comments.
> >
> > No I don't. This discussion so far has been about Linux code. I still
> > havent seen an argument explaining why hysteresis has to be optional.
>
> Fair enough. Looks like I'm holding this driver from being
> upstreamed, so I'll back off.
>
> Leo, sorry for misguiding you. Please bring back the hysteresis
> property you had in v1.
Not at all. I will add back hysteresis property and resend new patches.
Thanks,
Leo Yan
next prev parent reply other threads:[~2016-03-20 15:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 3:43 [PATCH v2 0/5] thermal: hisilicon: enable power allocator for Hi6220 Leo Yan
2016-02-26 3:43 ` Leo Yan
2016-02-26 3:43 ` Leo Yan
2016-02-26 3:43 ` [PATCH v2 1/5] thermal: change "hysteresis" as optional property Leo Yan
2016-02-26 3:43 ` Leo Yan
[not found] ` <1456458227-12950-2-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-03 10:45 ` Javi Merino
2016-03-03 10:45 ` Javi Merino
2016-03-03 10:45 ` Javi Merino
2016-03-03 16:29 ` Eduardo Valentin
2016-03-03 16:29 ` Eduardo Valentin
2016-03-03 16:29 ` Eduardo Valentin
2016-03-04 3:03 ` Leo Yan
2016-03-04 3:03 ` Leo Yan
2016-03-04 11:57 ` Javi Merino
2016-03-04 11:57 ` Javi Merino
2016-03-08 13:57 ` Leo Yan
2016-03-08 13:57 ` Leo Yan
2016-03-08 20:55 ` Eduardo Valentin
2016-03-08 20:55 ` Eduardo Valentin
2016-03-09 11:10 ` Javi Merino
2016-03-09 11:10 ` Javi Merino
2016-03-20 15:40 ` Leo Yan [this message]
2016-03-20 15:40 ` Leo Yan
2016-02-26 3:43 ` [PATCH v2 2/5] thermal: hisilicon: support to use any sensor Leo Yan
2016-02-26 3:43 ` Leo Yan
2016-02-26 3:43 ` [PATCH v2 3/5] thermal: hisilicon: fix IRQ imbalance enabling Leo Yan
2016-02-26 3:43 ` Leo Yan
2016-02-26 3:43 ` [PATCH v2 4/5] arm64: dts: register Hi6220's thermal sensor Leo Yan
2016-02-26 3:43 ` Leo Yan
2016-02-26 3:43 ` [PATCH v2 5/5] arm64: dts: register Hi6220's thermal zone for power allocator Leo Yan
2016-02-26 3:43 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160320154031.GA12693@leoy-linaro \
--to=leo.yan@linaro.org \
--cc=Punit.Agrawal@arm.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javi.merino@arm.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.