All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH] ARM: dts: sun6i: Add serial0 alias and stdout-path to a31s-primo81.dts
Date: Mon, 21 Mar 2016 08:50:21 +0100	[thread overview]
Message-ID: <20160321075021.GY30977@lukather> (raw)
In-Reply-To: <56ED184B.9000609@redhat.com>

On Sat, Mar 19, 2016 at 10:13:47AM +0100, Hans de Goede wrote:
> Hi,
> 
> On 18-03-16 18:48, Maxime Ripard wrote:
> >On Thu, Mar 17, 2016 at 02:28:03PM +0800, Chen-Yu Tsai wrote:
> >>On Wed, Mar 16, 2016 at 10:19 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> >>>u-boot uses the kernel as the canonical source for its sunxi dts files
> >>>and u-boot needs these.
> >>>
> >>>Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >>
> >>Acked-by: Chen-Yu Tsai <wens@csie.org>
> >
> >Queued, thanks!
> 
> I just got an of-list mail from Karsten Merker that you nacked the addition
> if this during the initial submission, because there are no accessible uart
> test pads on this tablet.
> 
> In that case the proper fix would be to change the u-boot defconfig to have:
> 
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> 
> Which will stop u-boot from panicking (with nowhere to print the panic msg)
> when it has no stdout-path.
> 
> Can you unqueue this one until we've figured out what the best fix is ?

Done, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160321/1933a8a8/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	linux-arm-kernel
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
	Karsten Merker <merker-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
Subject: Re: Re: [PATCH] ARM: dts: sun6i: Add serial0 alias and stdout-path to a31s-primo81.dts
Date: Mon, 21 Mar 2016 08:50:21 +0100	[thread overview]
Message-ID: <20160321075021.GY30977@lukather> (raw)
In-Reply-To: <56ED184B.9000609-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

On Sat, Mar 19, 2016 at 10:13:47AM +0100, Hans de Goede wrote:
> Hi,
> 
> On 18-03-16 18:48, Maxime Ripard wrote:
> >On Thu, Mar 17, 2016 at 02:28:03PM +0800, Chen-Yu Tsai wrote:
> >>On Wed, Mar 16, 2016 at 10:19 PM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> >>>u-boot uses the kernel as the canonical source for its sunxi dts files
> >>>and u-boot needs these.
> >>>
> >>>Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >>
> >>Acked-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
> >
> >Queued, thanks!
> 
> I just got an of-list mail from Karsten Merker that you nacked the addition
> if this during the initial submission, because there are no accessible uart
> test pads on this tablet.
> 
> In that case the proper fix would be to change the u-boot defconfig to have:
> 
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> 
> Which will stop u-boot from panicking (with nowhere to print the panic msg)
> when it has no stdout-path.
> 
> Can you unqueue this one until we've figured out what the best fix is ?

Done, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-03-21  7:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 14:19 [PATCH] ARM: dts: sun6i: Add serial0 alias and stdout-path to a31s-primo81.dts Hans de Goede
2016-03-16 14:19 ` Hans de Goede
2016-03-17  6:28 ` Chen-Yu Tsai
2016-03-17  6:28   ` Chen-Yu Tsai
2016-03-18 17:48   ` Maxime Ripard
2016-03-18 17:48     ` Maxime Ripard
2016-03-19  9:13     ` [linux-sunxi] " Hans de Goede
2016-03-19  9:13       ` Hans de Goede
2016-03-21  7:50       ` Maxime Ripard [this message]
2016-03-21  7:50         ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160321075021.GY30977@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.