From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: Brian Avery <avery.brian@gmail.com>
Cc: toaster@yoctoproject.org
Subject: Re: [PATCH 00/15] Build cancellation
Date: Mon, 21 Mar 2016 12:14:10 +0200 [thread overview]
Message-ID: <20160321101410.GA29533@linux.intel.com> (raw)
In-Reply-To: <CAKV_0ehVbC=CEcc316Q8WWS+3ifAdREe4HSb8f9kcYKoA6YDyw@mail.gmail.com>
On Sat, Mar 19, 2016 at 04:13:27PM -0700, Brian Avery wrote:
> 2) we cannot assume I am building in ~/poky/build. There are env
> variables to let us find where poky is $OEROOT for instance. My bin/sh
> is bash but I still got the following when building from
> $HOME/cow/test/ when poky was in $HOME/src/poky :
>
> : less toaster_ui.log
>
> bash: ../bitbake/bin/bitbake: No such file or directory
Should be fixed by this commit:
https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ed/toaster/project-build-dir-7880-cancel-dldir_sstatedir&id=a3566432d7d42939a482322abb7ead6026008d49
...
> 11) I’m not personally fond of having the sstate and dl_dir being set
> on the project creation page. they are available in the bitbake var
> page for each project which is nice. This is more a Belén thing. just
> putting my opinion down.
This should be alread fixed by Sujith. The fix is also in
ed/toaster/project-build-dir-7880-cancel-dldir_sstatedir
...
> So as far as upstreaming, I think we need to have the following 2
> things fixed first:
>
> 1) being able to run/build from an arbitrary dir and not assuming we
> are in the poky tree. (should be ez)
yes, it should be fixed already. see my comment above.
> 2) fixing the custom image stuff. Since the CI is the main selling
> point of the 2.1 release we need to make sure we don’t break it.
> (hopefully not too hard?)
OK, I'll try to look at it.
BTW, the full patchset has 42 patches and becomes hard to maintain.
We may need to consider upstreaming it in 2 or 3 steps if the above
fixes are hard to do.
Regards,
Ed
next prev parent reply other threads:[~2016-03-21 12:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 15:41 [PATCH 00/15] Build cancellation Ed Bartosh
2016-03-17 15:41 ` [PATCH 01/15] toaster: bldcontrol Add forceShutDown function to BitbakeController Ed Bartosh
2016-03-17 15:41 ` [PATCH 02/15] toaster: Move xhr calls for starting and stopping builds Ed Bartosh
2016-03-17 15:41 ` [PATCH 03/15] toaster: xhr Update the implementation of the build cancellation request Ed Bartosh
2016-03-17 15:41 ` [PATCH 04/15] toaster: libtoaster Update implementation of startABuild and cancelABuild Ed Bartosh
2016-03-17 15:41 ` [PATCH 05/15] toaster: update BuildEnvironmentController and BitbakeController Ed Bartosh
2016-03-17 15:41 ` [PATCH 06/15] toaster: models Add cancelled state to build outcome Ed Bartosh
2016-03-17 15:41 ` [PATCH 07/15] toaster: bldcontrol models Add a cancelling state the BuildRequest Ed Bartosh
2016-03-17 15:41 ` [PATCH 08/15] buildinfohelper: Add handler for cancelling a build Ed Bartosh
2016-03-17 15:41 ` [PATCH 09/15] toaster: tables BuildsTable exclude cancelled builds Ed Bartosh
2016-03-17 15:41 ` [PATCH 10/15] toaster: mrb_section template Add build cancel button Ed Bartosh
2016-03-17 15:41 ` [PATCH 11/15] toaster: models Exclude the CANCELLED builds from get_number_of_builds Ed Bartosh
2016-03-17 15:41 ` [PATCH 12/15] toaster: runbuilds Make runbuilds aware of the build CANCELLED state Ed Bartosh
2016-03-17 15:41 ` [PATCH 13/15] toaster: runbuilds Clean up runbuilds Ed Bartosh
2016-03-17 15:41 ` [PATCH 14/15] toaster: fix conflicting migrations Ed Bartosh
2016-03-17 15:41 ` [PATCH 15/15] toaster: use empty token Ed Bartosh
2016-03-19 23:13 ` [PATCH 00/15] Build cancellation Brian Avery
2016-03-20 17:12 ` Brian Avery
2016-03-21 10:34 ` Ed Bartosh
2016-03-21 18:07 ` Brian Avery
2016-03-21 18:37 ` Barros Pena, Belen
2016-03-21 21:18 ` Brian Avery
2016-03-22 13:45 ` Barros Pena, Belen
2016-03-21 10:14 ` Ed Bartosh [this message]
2016-03-21 11:14 ` Smith, Elliot
2016-03-21 11:36 ` Barros Pena, Belen
2016-03-21 18:04 ` Brian Avery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321101410.GA29533@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=avery.brian@gmail.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.